From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B55EC282D7 for ; Wed, 30 Jan 2019 23:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F16F620881 for ; Wed, 30 Jan 2019 23:23:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NgPszbzo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727097AbfA3XXR (ORCPT ); Wed, 30 Jan 2019 18:23:17 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:40282 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726233AbfA3XXQ (ORCPT ); Wed, 30 Jan 2019 18:23:16 -0500 Received: by mail-qt1-f193.google.com with SMTP id k12so1558887qtf.7 for ; Wed, 30 Jan 2019 15:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=AU7V26ikyvZZXbIB48jadtkrpgiuNXW6OxwegLD0tSI=; b=NgPszbzom4GV7x5/6MBj2p0LsmbBGDIfURFSQU8ecBj5DQ/Y12Ll9OZ50QFOFUxsdQ WKCLRxPsd/iU2RQpNx6OQfI3957O+0MQhHrJPpIaovMWu8hj9qPIsANU0WaMmM3WEoAw fQIZQ09/tmQnTlasaP5Vu7PHkvDIiGXEC9pK9nNI1VFjTGFvhiyrHFF2d5qfK88Q0EFf jkSFFYwsUu2H/YpifFKzV9oSClkakaHpVCJHckdsRk007hB2Ow0PqxVeg29BiafiOrGc 90YgPNOWge5LhRB+RY4O9rfUqFBPPEq+Qm5Nw9jYth/zusWxoPFC1YvT/V0+ca0FNNZK 2dfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=AU7V26ikyvZZXbIB48jadtkrpgiuNXW6OxwegLD0tSI=; b=KaQHvbVC4HC3GTu7tCrONcdcHKr+fQtu6e0Gsalqm20CFZlFu2XFHCCXtqgFlKSDSd ztN8k/vkDHK7w/FZkTqNLR8YRQtgcMw5N1jS4cCRIgvTYEuCwPfqiQkAPuSVTfaZuIpz H8b4AZ87Pgpl3XZnrdocegxsIvB2ea7CKYS+fpTUZEsyKuo1u4vOxxo6tfZwvT6LpzqR 9JyCiV8fSecUSVMqokytOIlQAVhxmS49rsxYYh3kn56XxD4u/iW7BUtEHGkJ0ywe0FTy jKkPxgtMSU3Y6kZC0nj7vh9pkE6NT2B+p0m5uNc7r/s7fN9wDK0jms0gEWOQh94vIw32 /FXg== X-Gm-Message-State: AJcUukeaobY90E7p9o+WH4HIGr3PP2mMJn59VUfcBUJpSUw3kt3DQIfj WKkpkX6Bu49xwgTga1IY6Z+ALcNyUO0= X-Google-Smtp-Source: ALg8bN5hyPp4/z/JTADabJAD8kvrzdnMdYH0pFJnDuAPXWZxtjrH3vs17u3fWIRCfTbOB48242t0xw== X-Received: by 2002:aed:24b7:: with SMTP id t52mr32360887qtc.131.1548887341227; Wed, 30 Jan 2019 14:29:01 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id 70sm8828808qkc.52.2019.01.30.14.29.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 14:29:00 -0800 (PST) Date: Wed, 30 Jan 2019 17:28:59 -0500 Message-ID: <20190130172859.GB3207@t480s.localdomain> From: Vivien Didelot To: Florian Fainelli Cc: netdev@vger.kernel.org, Florian Fainelli , andrew@lunn.ch, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: Re: [PATCH net-next v2 07/12] net: dsa: Add ability to program multicast filter for CPU port In-Reply-To: <20190130005548.2212-8-f.fainelli@gmail.com> References: <20190130005548.2212-1-f.fainelli@gmail.com> <20190130005548.2212-8-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Florian, On Tue, 29 Jan 2019 16:55:43 -0800, Florian Fainelli wrote: > +static int dsa_slave_sync_unsync_mdb_addr(struct net_device *dev, > + const unsigned char *addr, bool add) > +{ > + struct switchdev_obj_port_mdb mdb = { > + .obj = { > + .id = SWITCHDEV_OBJ_ID_HOST_MDB, > + .flags = SWITCHDEV_F_DEFER, > + }, > + .vid = 0, > + }; > + int ret = -EOPNOTSUPP; Assignment unneeded here. > + > + ether_addr_copy(mdb.addr, addr); > + if (add) > + ret = switchdev_port_obj_add(dev, &mdb.obj, NULL); > + else > + ret = switchdev_port_obj_del(dev, &mdb.obj); > + > + return ret; > +} > + > +static int dsa_slave_sync_mdb_addr(struct net_device *dev, > + const unsigned char *addr) > +{ > + return dsa_slave_sync_unsync_mdb_addr(dev, addr, true); > +} > + > +static int dsa_slave_unsync_mdb_addr(struct net_device *dev, > + const unsigned char *addr) > +{ > + return dsa_slave_sync_unsync_mdb_addr(dev, addr, false); > +} This wrapper isn't necessary IMO. I'd go with something like: static int dsa_slave_sync(struct net_device *dev, const unsigned char *addr) { struct switchdev_obj_port_mdb mdb = { .obj.id = SWITCHDEV_OBJ_ID_HOST_MDB, .obj.flags = SWITCHDEV_F_DEFER, }; ether_addr_copy(mdb.addr, addr); return switchdev_port_obj_add(dev, &mdb.obj, NULL); } static int dsa_slave_unsync(struct net_device *dev, const unsigned char *addr) { struct switchdev_obj_port_mdb mdb = { .obj.id = SWITCHDEV_OBJ_ID_HOST_MDB, .obj.flags = SWITCHDEV_F_DEFER, }; ether_addr_copy(mdb.addr, addr); return switchdev_port_obj_del(dev, &mdb.obj); } We may eventually wrap this cryptic netdevery in: static int dsa_slave_mc_sync(struct net_device *dev) { return __hw_addr_sync_dev(&dev->mc, dev, dsa_slave_sync, dsa_slave_unsync); } static void dsa_slave_mc_unsync(struct net_device *dev) { __hw_addr_unsync_dev(&dev->mc, dev, dsa_slave_sync); } > + > static int dsa_slave_open(struct net_device *dev) > { > struct net_device *master = dsa_slave_to_master(dev); > @@ -126,6 +159,8 @@ static int dsa_slave_close(struct net_device *dev) > > dev_mc_unsync(master, dev); > dev_uc_unsync(master, dev); > + __hw_addr_unsync_dev(&dev->mc, dev, dsa_slave_unsync_mdb_addr); > + > if (dev->flags & IFF_ALLMULTI) > dev_set_allmulti(master, -1); > if (dev->flags & IFF_PROMISC) > @@ -150,7 +185,17 @@ static void dsa_slave_change_rx_flags(struct net_device *dev, int change) > static void dsa_slave_set_rx_mode(struct net_device *dev) > { > struct net_device *master = dsa_slave_to_master(dev); > + struct dsa_port *dp = dsa_slave_to_port(dev); > > + /* If the port is bridged, the bridge takes care of sending > + * SWITCHDEV_OBJ_ID_HOST_MDB to program the host's MC filter > + */ > + if (netdev_mc_empty(dev) || dp->bridge_dev) > + goto out; > + > + __hw_addr_sync_dev(&dev->mc, dev, dsa_slave_sync_mdb_addr, > + dsa_slave_unsync_mdb_addr); And check the returned error code. > +out: > dev_mc_sync(master, dev); > dev_uc_sync(master, dev); > } Thanks, Vivien