From: Ursula Braun <ubraun@linux.ibm.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
raspl@linux.ibm.com, ubraun@linux.ibm.com
Subject: [PATCH net 1/9] net/smc: fix another sizeof to int comparison
Date: Wed, 30 Jan 2019 18:51:00 +0100 [thread overview]
Message-ID: <20190130175108.103221-2-ubraun@linux.ibm.com> (raw)
In-Reply-To: <20190130175108.103221-1-ubraun@linux.ibm.com>
Comparing an int to a size, which is unsigned, causes the int to become
unsigned, giving the wrong result. kernel_sendmsg can return a negative
error code.
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
---
net/smc/smc_clc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c
index 776e9dfc915d..d53fd588d1f5 100644
--- a/net/smc/smc_clc.c
+++ b/net/smc/smc_clc.c
@@ -378,7 +378,7 @@ int smc_clc_send_decline(struct smc_sock *smc, u32 peer_diag_info)
vec.iov_len = sizeof(struct smc_clc_msg_decline);
len = kernel_sendmsg(smc->clcsock, &msg, &vec, 1,
sizeof(struct smc_clc_msg_decline));
- if (len < sizeof(struct smc_clc_msg_decline))
+ if (len < 0 || len < sizeof(struct smc_clc_msg_decline))
len = -EPROTO;
return len > 0 ? 0 : len;
}
--
2.16.4
next prev parent reply other threads:[~2019-01-30 17:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 17:50 [PATCH net 0/9] net/smc: fixes 2019-01-30 Ursula Braun
2019-01-30 17:51 ` Ursula Braun [this message]
2019-01-30 17:51 ` [PATCH net 2/9] net/smc: allow 16 byte pnetids in netlink policy Ursula Braun
2019-01-30 17:51 ` [PATCH net 3/9] net/smc: prevent races between smc_lgr_terminate() and smc_conn_free() Ursula Braun
2019-01-30 17:51 ` [PATCH net 4/9] net/smc: don't wait for send buffer space when data was already sent Ursula Braun
2019-01-30 17:51 ` [PATCH net 5/9] net/smc: recvmsg and splice_read should return 0 after shutdown Ursula Braun
2019-01-30 17:51 ` [PATCH net 6/9] net/smc: do not wait under send_lock Ursula Braun
2019-01-30 17:51 ` [PATCH net 7/9] net/smc: call smc_cdc_msg_send() " Ursula Braun
2019-01-30 17:51 ` [PATCH net 8/9] net/smc: use device link provided in qp_context Ursula Braun
2019-01-30 17:51 ` [PATCH net 9/9] net/smc: fix use of variable in cleared area Ursula Braun
2019-02-01 22:48 ` [PATCH net 0/9] net/smc: fixes 2019-01-30 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130175108.103221-2-ubraun@linux.ibm.com \
--to=ubraun@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).