From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBD8C282D7 for ; Thu, 31 Jan 2019 02:27:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BFB220881 for ; Thu, 31 Jan 2019 02:27:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="dwZHqxL/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbfAaC1F (ORCPT ); Wed, 30 Jan 2019 21:27:05 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:33971 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbfAaC1E (ORCPT ); Wed, 30 Jan 2019 21:27:04 -0500 Received: by mail-qk1-f195.google.com with SMTP id q8so1076923qke.1 for ; Wed, 30 Jan 2019 18:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=nNAPVdBNZcHM8oVFGRDLaMXGxGWBLjVJ7CeQgINMzSY=; b=dwZHqxL/bNmUGzwxAkfeMkiGrUh/WE+6+feiWLclguHZvKMB7ytq/rUm8xksFiYGaC MJgcD7vH2flusWLjI9LCun8OLUBklCJOFEKCWv4QvsZE14Mmj8J/0RS0ZstPKvzi1RWm coCdNR+su8tk7RhfKmaYdmxHoEyGJ7X6cd+tAGlAYfr8ckXxjBM4my+yZL7FIeCvNi1u 4FcMdK7KO2R6ogiBJcBeNBCqa86HuQRja/a0zDve81qLEdhQXH1LVoR98N8UhjyIp9nC cmeSoU08ZwdA4Z7V3Q2Z0VUJWAUhXcwz3JdRKQDxo944ys7du4CcPcJUbgvsCVp1ygtT Kqrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=nNAPVdBNZcHM8oVFGRDLaMXGxGWBLjVJ7CeQgINMzSY=; b=nNmWoIQuYMRApHA2vIQTj28BdYMkuAFxUvEnA0QfdWeS7zV7Zjr0dnSCCU1SZ8xW9K yZedAd1lrmDd13IunWyZPofnGU5LInpeZvAKg8CMqf+YndWuqTNM1HJK35DERCZELeN3 gDhWMM7UDooooINVW1bNpQk/4/6JcYfh+gDT31QRZxrPvEi6LiZuOMUE1ttjfdxa2j0B ac3NJIfmUfGCs9dej7HDVkCEjulpsmWFHuV/MLYn3WuoMxGRIdIGfiMURx0WL/s0iQGh 3T90Mi+Ln4cYDnP3MH2O8g0Yc00Sn70UkKjM52TT6KKMcDjYzrgmJTqPJhGonGChvBSI z0dQ== X-Gm-Message-State: AJcUukdK5H3IEBPsLsX7RbkprLDMXQp+6xxp4pRgDhKZepmMN4tQltVA ac3UuHENaFCl5K4SMql553N8cw== X-Google-Smtp-Source: ALg8bN65mXIIOdxnzKnzP3b2yX9ktKo9hF3lS56QD4sVBjTsxJIQs8LDj+we4iTjJTHonljks7T6DA== X-Received: by 2002:a37:9bc9:: with SMTP id d192mr28561342qke.221.1548901623619; Wed, 30 Jan 2019 18:27:03 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id w22sm4040346qtw.71.2019.01.30.18.27.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 18:27:03 -0800 (PST) Date: Wed, 30 Jan 2019 18:26:53 -0800 From: Jakub Kicinski To: Jesper Dangaard Brouer Cc: Maciej Fijalkowski , daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples Message-ID: <20190130182653.0f3bb01e@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190130200859.16237d3f@redhat.com> References: <20190128191613.11705-1-maciejromanfijalkowski@gmail.com> <20190128191613.11705-6-maciejromanfijalkowski@gmail.com> <20190129090000.3c34b873@redhat.com> <20190129123405.787746f7@redhat.com> <20190130191248.00000167@gmail.com> <20190130200859.16237d3f@redhat.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 30 Jan 2019 20:08:59 +0100, Jesper Dangaard Brouer wrote: > > I'll post a v5 with libbpf_strerror() usage when bpf_set_link_xdp_fd failed in > > samples but at this point it will only give us a standard "device or resource > > busy" error > > That is a good first iteration improvement. And if QA complains, I can > quickly diagnose and explain the issue, based on this generic message, > without digging further and wasting more time. > > > , so if we need some more meaningful message that libbpf will give > > us then I guess we need to define a new libbpf_errno entry (as well as entry in > > libbpf_strerror_table for this new errno value) and set the errno in > > bpf_set_link_xdp_fd in case of a failure? > > It likely require more work do provide more meaningful messages, and I > guess it is out-of-scope for your patchset. Perhaps we could put the error message in extack instead?