From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=auZG=QG=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ED9D2C282D8
	for <netdev@archiver.kernel.org>; Wed, 30 Jan 2019 19:09:09 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id BA2EA2087F
	for <netdev@archiver.kernel.org>; Wed, 30 Jan 2019 19:09:09 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="DzYyBDpU"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2387523AbfA3TJI (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 30 Jan 2019 14:09:08 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:33051 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728197AbfA3TJH (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 30 Jan 2019 14:09:07 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=DcJW9OLxu9x6Esj1bprVcAHfQDRG9G7BPpn1esabqkg=; b=DzYyBDpUkUkifryNX8MQmDspD1
        FvQ/RbHLDXnVkFVYFtRc6o1+0Wy2tKVgJIPIbAnTrU7TKvZTZVn02NCJEXBGMNPFF0/p99MWZ38z4
        ertaKwc5vRt5U70x6fc3TJ+IuCQup+gQhHu/VV19T1gUf7DqutM1MHd36P3KJhuQiYGs=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1govEL-0006p9-72; Wed, 30 Jan 2019 20:09:01 +0100
Date:   Wed, 30 Jan 2019 20:09:01 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     John David Anglin <dave.anglin@bell.net>
Cc:     Russell King <linux@arm.linux.org.uk>,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Subject: Re: net: phylink: dsa: mv88e6xxx: flaky link detection on switch
 ports with internal PHYs
Message-ID: <20190130190901.GH15050@lunn.ch>
References: <49eec816-9238-c893-0860-602aa8965515@bell.net>
 <20190122202834.GB12052@lunn.ch>
 <09fce2e0-9dd2-ea30-7e7d-72f04eede68b@bell.net>
 <20190122223649.GD3634@lunn.ch>
 <e74f35e2-d81c-7f86-a6b3-7cecce035ce9@bell.net>
 <20190123002240.GF3634@lunn.ch>
 <f13cf118-79cb-0430-8605-53a662fe53d7@bell.net>
 <20190130172818.GJ21904@lunn.ch>
 <c45116c4-ce1d-8a59-dc8b-857247e9c840@bell.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c45116c4-ce1d-8a59-dc8b-857247e9c840@bell.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> In /proc/interrupts, the switch interrupts are shown as edge.  The only
> place that I see where this
> is potentially set is mv88e6xxx_g2_watchdog_setup() where the call to
> request_threaded_irq() passes
> "IRQF_ONESHOT | IRQF_TRIGGER_FALLING".  Does this need to change?

Hi Dave

Device tree determines how the interrupt is configured.  It is the
second part of the interrupts property.

       Andrew