From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F96C282D7 for ; Wed, 30 Jan 2019 21:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D94B6218D2 for ; Wed, 30 Jan 2019 21:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732917AbfA3VPS (ORCPT ); Wed, 30 Jan 2019 16:15:18 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:41717 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729410AbfA3VPQ (ORCPT ); Wed, 30 Jan 2019 16:15:16 -0500 Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1goxCR-0004Zk-RL; Wed, 30 Jan 2019 16:15:11 -0500 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.15.2/8.14.6) with ESMTP id x0UL8WX8006490; Wed, 30 Jan 2019 16:08:32 -0500 Received: (from linville@localhost) by localhost.localdomain (8.15.2/8.15.2/Submit) id x0UL8Wo9006489; Wed, 30 Jan 2019 16:08:32 -0500 Date: Wed, 30 Jan 2019 16:08:32 -0500 From: "John W. Linville" To: Nicholas Nunley Cc: Jeff Kirsher , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com Subject: Re: [ethtool 1/6] ethtool: move option parsing related code into function Message-ID: <20190130210831.GD19981@tuxdriver.com> References: <20190117230313.20248-1-nicholas.d.nunley@intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <20190117230313.20248-1-nicholas.d.nunley@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 17, 2019 at 03:03:08PM -0800, Nicholas Nunley wrote: > Move option parsing code into find_option function. > > No behavior changes. > > Based on patch by Kan Liang > > Signed-off-by: Nicholas Nunley Well, after looking at this series for a while I had decided to apply it. But when I applied it and did a 'make distcheck', I got this: ... gcc -DTEST_ETHTOOL -g -O2 -o test-features test_features-test-features.o test_features-test-common.o test_features-ethtool.o test_features-rxclass.o test_features-amd8111e.o test_features-de2104x.o test_features-dsa.o test_features-e100.o test_features-e1000.o test_features-et131x.o test_features-igb.o test_features-fec_8xx.o test_features-ibm_emac.o test_features-ixgb.o test_features-ixgbe.o test_features-natsemi.o test_features-pcnet32.o test_features-realtek.o test_features-tg3.o test_features-marvell.o test_features-vioc.o test_features-smsc911x.o test_features-at76c50x-usb.o test_features-sfc.o test_features-stmmac.o test_features-sff-common.o test_features-sfpid.o test_features-sfpdiag.o test_features-ixgbevf.o test_features-tse.o test_features-vmxnet3.o test_features-qsfp.o test_features-fjes.o test_features-lan78xx.o -lm make[2]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make check-TESTS make[2]: Entering directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make[3]: Entering directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' FAIL: test-cmdline PASS: test-features ============================================================================ Testsuite summary for ethtool 4.19 ============================================================================ # TOTAL: 2 # PASS: 1 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See ./test-suite.log Please report to netdev@vger.kernel.org ============================================================================ make[3]: *** [Makefile:1942: test-suite.log] Error 1 make[3]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make[2]: *** [Makefile:2050: check-TESTS] Error 2 make[2]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make[1]: *** [Makefile:2264: check-am] Error 2 make[1]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make: *** [Makefile:2186: distcheck] Error 1 ... I'll attach ./ethtool-4.19/_build/sub/test-suite.log to this message. Obviously we need whatever additional changes are needed to get 'make check-TESTS' to pass legitimately. John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="test-suite.log" ==================================== ethtool 4.19: ./test-suite.log ==================================== # TOTAL: 2 # PASS: 1 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: test-cmdline ================== E: ethtool -s devname returns 1 E: ethtool --change devname speed 100 duplex half mdix auto returns 1 E: ethtool -s devname duplex half returns 1 E: ethtool --change devname port tp returns 1 E: ethtool -s devname autoneg on returns 1 E: ethtool --change devname advertise 0x1 returns 1 E: ethtool --change devname advertise 0xf returns 1 E: ethtool --change devname advertise 0Xf returns 1 E: ethtool --change devname advertise 1 returns 1 E: ethtool --change devname advertise f returns 1 E: ethtool --change devname advertise 01 returns 1 E: ethtool --change devname advertise 0f returns 1 E: ethtool --change devname advertise 0xfffffffffffffffffffffffffffffffff returns 1 E: ethtool --change devname advertise fffffffffffffffffffffffffffffffff returns 1 E: ethtool --change devname advertise 0x0000fffffffffffffffffffffffffffff returns 1 E: ethtool --change devname advertise 0000fffffffffffffffffffffffffffff returns 1 E: ethtool -s devname phyad 1 returns 1 E: ethtool --change devname xcvr external returns 1 E: ethtool -s devname wol p returns 1 E: ethtool -s devname sopass 01:23:45:67:89:ab returns 1 E: ethtool -s devname msglvl 1 returns 1 E: ethtool -s devname msglvl hw on rx_status off returns 1 E: ethtool --change devname speed 100 duplex half port tp autoneg on advertise 0x1 phyad 1 xcvr external wol p sopass 01:23:45:67:89:ab msglvl 1 returns 1 FAIL test-cmdline (exit status: 1) --Q68bSM7Ycu6FN28Q--