From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5464C282D7 for ; Wed, 30 Jan 2019 21:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 809602184D for ; Wed, 30 Jan 2019 21:35:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kcg9DGnf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388181AbfA3Vfw (ORCPT ); Wed, 30 Jan 2019 16:35:52 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:35517 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730971AbfA3Vfw (ORCPT ); Wed, 30 Jan 2019 16:35:52 -0500 Received: by mail-qk1-f194.google.com with SMTP id w204so704990qka.2 for ; Wed, 30 Jan 2019 13:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zAww9q7vLmQr+Yk7a0NJJ8V60VrOs/VUJ9NWMagQbcg=; b=kcg9DGnfjb/NZ+UNJbY6NudNhtH/wUFwuPGNKnBfl65lzGdaXOtWD2YFMM8RVaASZo SufZvPUQ1KfgM9c8fkfVomtwaLt7x/TV3nWJNPyXmePwwlGd42a6scIlgZykAyEfh2rt aVNln3vS7iCDhlJ2/LjC/jX+hjbXJZREG1UL0l6KW3au2SSY7jkrHIHHX16laMPXc4lU IA3eGbSdmKBGm9PE373ArqHZDShrhmMQ8oEg/tZUIcK/JXv8mJBK4zwF4OIPm3xGj6AQ sW2IXfZ3s53O7igpAXqYpEqRG9i/ihX8GLx46l9yrj/tgyGzmW1ucd09uvzJzut8nF4c dahA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zAww9q7vLmQr+Yk7a0NJJ8V60VrOs/VUJ9NWMagQbcg=; b=L2rux9aZVFdL0GJi5Cv74IfhkIKy07lX8fatzScBcghGa1UP2/eWkuMoYprGfK4hMg CesIDGG0eI+2VsMjDGnKmLAYBDS1/zOMlypa+/fU0wdhb9N1vHukOR/iSkSdMsUtVpVY 5OJAwh4MclwDPERxxWtjOIxDcfmlm+VjvKhFJJVutlRGdscBtASVSWy0Sp4uLQDRZpoX 9D9k2DlFF5Sm18Wsx2RoD4X5dZx9ieoUmVZZRWjP4FpUh4VpBtJaryjSS+USCsB0UiSp y5Uq4RKftxoihSJq9x51OC69bBQ/bmCaPyPi5bOwfqiJ/pMjHB233AJPo5AH28NjmraQ 5ecw== X-Gm-Message-State: AJcUukcbDa5C3xAH13Chk9vDn2+lE83k+6f/vZ+d+4CGg/TT0e5bXTZ2 E3R4i/vCOA8dgzzEXCxy4IE= X-Google-Smtp-Source: ALg8bN6o4yHm0iFKW0w5ngmUq3RoR5hRy+HjkB9/5fPU0tSATFhJdwcKLE0N+RvmwwFhWXuMc8dmfg== X-Received: by 2002:a37:97c1:: with SMTP id z184mr29038627qkd.39.1548884151291; Wed, 30 Jan 2019 13:35:51 -0800 (PST) Received: from MILA.cisco.com ([192.119.12.114]) by smtp.gmail.com with ESMTPSA id m68sm2412166qte.49.2019.01.30.13.35.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 13:35:50 -0800 (PST) From: Ramin Farajpour Cami To: davem@davemloft.net Cc: herbert@gondor.apana.org.au, steffen.klassert@secunet.com, netdev@vger.kernel.org, Ramin Farajpour Cami Subject: [PATCH] net: esp4: Fix double free on esp4 functions Date: Wed, 30 Jan 2019 21:35:42 +0000 Message-Id: <20190130213542.17313-1-ramin.blackhat@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org key/tmp is being kfree'd twice,once in the "aalg_desc->uinfo.auth.icv_fullbits / 8 != crypto_aead_authsize(aead)" call to "free_key",twice When "crypto_aead_setauthsize(aead, x->aalg->alg_trunc_len / 8)" fails call to again "free_key", Signed-off-by: Ramin Farajpour Cami --- net/ipv4/esp4.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index 5459f41fc26f..5a66e47641b0 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -467,6 +467,7 @@ int esp_output_tail(struct xfrm_state *x, struct sk_buff *skb, struct esp_info * error_free: kfree(tmp); + tmp = NULL; error: return err; } @@ -959,7 +960,7 @@ static int esp_init_authenc(struct xfrm_state *x) free_key: kfree(key); - + key = NULL; error: return err; } -- 2.11.0