From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5688C282D7 for ; Wed, 30 Jan 2019 22:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54F1D20857 for ; Wed, 30 Jan 2019 22:59:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="OuFIXxYw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727046AbfA3W7e (ORCPT ); Wed, 30 Jan 2019 17:59:34 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51974 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726783AbfA3W7Z (ORCPT ); Wed, 30 Jan 2019 17:59:25 -0500 Received: by mail-wm1-f65.google.com with SMTP id b11so562036wmj.1 for ; Wed, 30 Jan 2019 14:59:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4ZgZaceT5AXF6dSQPWDKlYs+tZWV/0VJOY3I/znOD24=; b=OuFIXxYwezlWMVu5Ul3/UNRbO3lUjENBhB/kiYr8bEyitKYJsjDtSSyVl8lk6LJvQ7 9Vglh7T7p9NttFLXSzYDgSDHp5yIzfjOAPOenj17guqBhuiPNyHrI9Pb5dKyba0b8fEE y00iTTiOm9IbnbhNrdRBnQ3y94xaYunl/Swe3Jd6fXz8/IwTOvOgnzdEChLMZCwm/6Vb uV9Ndien5W+s53MHUUd2vh3oZfBo35D8/Mhjb75sEO+EmGpxQ1SXUbo1FGBnObwX+lWg J3W72HzO6BzXOd9fEGsREWenUW96QWfguxVceFE34WklAQg/gqkDkwD8Gx6iyowakFAN CliA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4ZgZaceT5AXF6dSQPWDKlYs+tZWV/0VJOY3I/znOD24=; b=Ge12DGvEhv6ZBH6diQXzjfC+9IUlM8X7/fpue0m/yownazZwaYxDRIK4jt5AA4XYkR VzJn59dNdNsflUkWQn8IxB+NRMq/pYqp3MHWBmjFtNVYHPHawB7bpfda/jxKgpALSlVn N9PbVwtIlvJvebUqFxc24Tfs7+cNpwNx1sY+fH/yRyRLVObJWM9EzF/0t3w6W5fLwjnM r3xfDJAaqjPhRFFVSd3h6fuzgJayhg0pLY/nAYQuPrGchvu4/zOAWcQtwPhCSdXAQBkm UhAWTnhLXzjdLU1ZdXneckjEK54GhXA/qh0gkGhvhf0M6o9BkN+pnm3PTaNa4fKxy/Af MpiQ== X-Gm-Message-State: AHQUAubIsYV/A8iyP0I6fCpjnjknSy7lKvCqfIRdOYTRjs0KAjhnjHz4 Iz0KvcwZdEOFaSrwPVPZZDbpXa/ZNmY= X-Google-Smtp-Source: AHgI3IZ+QApYEOutgdWfmuCP7LJeUfBqikuXYLo2glaj7k9bk+VndeNPXpxezQfrJAfFdAmWfcxa6g== X-Received: by 2002:a1c:44c5:: with SMTP id r188mr7569979wma.151.1548887341272; Wed, 30 Jan 2019 14:29:01 -0800 (PST) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id n127sm4703169wmd.20.2019.01.30.14.29.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 14:29:00 -0800 (PST) Date: Wed, 30 Jan 2019 23:19:59 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com Subject: Re: [PATCH net-next v2 6/7] nfp: devlink: report the running and flashed versions Message-ID: <20190130221959.GF349@nanopsycho.orion> References: <20190130190513.25718-1-jakub.kicinski@netronome.com> <20190130190513.25718-7-jakub.kicinski@netronome.com> <20190130215752.GD349@nanopsycho.orion> <20190130142158.433af0ce@cakuba.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130142158.433af0ce@cakuba.hsd1.ca.comcast.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Jan 30, 2019 at 11:21:58PM CET, jakub.kicinski@netronome.com wrote: >On Wed, 30 Jan 2019 22:57:52 +0100, Jiri Pirko wrote: >> >+/* Control processor FW version, FW is responsible for house keeping tasks, >> >+ * PHY control etc. >> >+ */ >> >+#define DEVLINK_VERSION_GENERIC_FW_MGMT "fw.mgmt" >> >+/* Data path microcode controlling high-speed packet processing */ >> >+#define DEVLINK_VERSION_GENERIC_FW_APP "fw.app" >> >+/* UNDI software version */ >> >+#define DEVLINK_VERSION_GENERIC_FW_UNDI "fw.undi" >> >+/* NCSI support/handler version */ >> >+#define DEVLINK_VERSION_GENERIC_FW_NCSI "fw.ncsi" >> >> Same here. Also, please put "INFO" in the names to respect the namespacing > >Ack on all, and thanks for the reviews! Do you also think I should add >a doc with them? I was going back and forth on that.. Adding docs would not do harm I believe. Thanks!