From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E411C169C4 for ; Thu, 31 Jan 2019 07:28:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30A8D20881 for ; Thu, 31 Jan 2019 07:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731434AbfAaH2B (ORCPT ); Thu, 31 Jan 2019 02:28:01 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:54506 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726543AbfAaH2B (ORCPT ); Thu, 31 Jan 2019 02:28:01 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 8005C201DC; Thu, 31 Jan 2019 08:27:59 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rVD3LwYayOWC; Thu, 31 Jan 2019 08:27:58 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id DE7662019C; Thu, 31 Jan 2019 08:27:58 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.435.0; Thu, 31 Jan 2019 08:27:58 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 6EFB4318040E; Thu, 31 Jan 2019 08:27:58 +0100 (CET) Date: Thu, 31 Jan 2019 08:27:58 +0100 From: Steffen Klassert To: Ramin Farajpour Cami CC: Eric Dumazet , , Herbert Xu , Subject: Re: [PATCH] net: esp4: Fix double free on esp4 functions Message-ID: <20190131072758.GK3581@gauss3.secunet.de> References: <20190130213542.17313-1-ramin.blackhat@gmail.com> <38d987a0-7cc4-1565-00d4-22fdd04d7894@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 4E093E97-6A66-4E35-BE87-47BAA697AAAF X-G-Data-MailSecurity-for-Exchange-ProcessedOnRouted: True Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 31, 2019 at 06:32:07AM +0000, Ramin Farajpour Cami wrote: > Hi Eric, > > I going to for avoid double free of resource identifiers we should set > variables initialized in "tmp/key" to NULL if an error occurred int the > "esp_init_authenc()" and "esp_output_tail()" attempts to free the memory > again.my means like this patch c7055fd15ff46d92eb0dd1c16a4fe010d58224c8 > There is a big difference between the above-noted patch and your patch. You really have to understand the code you are trying to change.