From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CA6C169C4 for ; Thu, 31 Jan 2019 07:49:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37E6820870 for ; Thu, 31 Jan 2019 07:49:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Q3o037Rr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725885AbfAaHtJ (ORCPT ); Thu, 31 Jan 2019 02:49:09 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43318 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725827AbfAaHtI (ORCPT ); Thu, 31 Jan 2019 02:49:08 -0500 Received: by mail-wr1-f68.google.com with SMTP id r10so2090940wrs.10 for ; Wed, 30 Jan 2019 23:49:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xpb92XdmWMjzujrvwA5J3aTnLqulDVByUPgptHXgyT8=; b=Q3o037RrfEdFTbJhurSnZnKNNYgfbP+lFeh3nCWrduEWILkQXFJUE2CWzCo9hnfcBp EzHVVQCIDh93z61F/QoKB+mmWKhhGGkQsLVFwvvBSMA5+mBDMNWS2/qHqf4bPinqKnA1 wijNsL+JPMpgZ7DTlgpYG3o2c+5msBwewX8pjpkOWjMmgg5gnl8ESzIbqCZMKAfVs1iH VZurIkYkS1N26+kOY5jovHof/fnbtP9N4IuzU6B8WZawwqig5+oMtFF0uyhiEf20gmD8 hdDsRYlXJEZ8wz24Bt0FpL3/lnzTB/pIMLAQL/7UBmtG7rwxJWHbJ9b0cBvtYBa8wR44 mL/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xpb92XdmWMjzujrvwA5J3aTnLqulDVByUPgptHXgyT8=; b=jxAz8wuPu97p6zfW771qX01cR4geSl7G0SRAWyKJnagEUBzyFNFewwnumZmbECIxVx GlTYzWIXhyEk+kL3GlyqsgQTFb1+hC2dAs7T6yxBCIopRJLMANt0nRKrf08gtpIU2b/p CiR1keiqEDvQQ1oJ+OqFFXaSjHXdhILlxkfvF/8Cykczev6IewT1L/luXic2/ThWovdH ecphB5idkkYPx2x/u5Mi8CEt8ygAUqcEw1XttjBBTueZ8A2PoT1pbpl7bUPVj9nFWQeM hA6CEdJ5LIebX22A+Vg5hhcehRzv44qTt1+oBvTNLWighiSjeF8Ck0sBjXE99OdE9pvr hZCA== X-Gm-Message-State: AJcUukfWN9uI/Nqg7BZolxPrzeP7N8pF9+pCO1qbB6sXPnSTtMtcIUoc 0toQs+mAvji2vak7COuSwjyYTA== X-Google-Smtp-Source: ALg8bN62xn0qIveUS+wvETYlHRWZcSWPTxqzdblDjSmxdhSCKvzsBxwezolZyw1b6Gia+NOPKxmjrg== X-Received: by 2002:adf:e407:: with SMTP id g7mr32512273wrm.277.1548920947130; Wed, 30 Jan 2019 23:49:07 -0800 (PST) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id 133sm9685317wme.9.2019.01.30.23.49.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 23:49:06 -0800 (PST) Date: Thu, 31 Jan 2019 08:40:05 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com Subject: Re: [PATCH net-next v3 1/8] devlink: add device information API Message-ID: <20190131074005.GA2523@nanopsycho.orion> References: <20190130234133.4298-1-jakub.kicinski@netronome.com> <20190130234133.4298-2-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130234133.4298-2-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Jan 31, 2019 at 12:41:26AM CET, jakub.kicinski@netronome.com wrote: >ethtool -i has served us well for a long time, but its showing >its limitations more and more. The device information should >also be reported per device not per-netdev. > >Lay foundation for a simple devlink-based way of reading device >info. Add driver name and device serial number as initial pieces >of information exposed via this new API. > >v3: > - rename helpers (Jiri); > - rename driver name attr (Jiri); > - remove double spacing in commit message (Jiri). >RFC v2: > - wrap the skb into an opaque structure (Jiri); > - allow the serial number of be any length (Jiri & Andrew); > - add driver name (Jonathan). > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko