From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48165C169C4 for ; Thu, 31 Jan 2019 07:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19F7120870 for ; Thu, 31 Jan 2019 07:50:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="Y/GLOwy1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726341AbfAaHuU (ORCPT ); Thu, 31 Jan 2019 02:50:20 -0500 Received: from mail-eopbgr140089.outbound.protection.outlook.com ([40.107.14.89]:20902 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725875AbfAaHuT (ORCPT ); Thu, 31 Jan 2019 02:50:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2eD3KPeoVlu7npR5ztT/1t9KK+w/8t7OITkO6qjkulg=; b=Y/GLOwy1XipzSt7J3og0qDH0PWWcO5UGJzhhTCHTrRZmvqP4G4LAd0FJfgiAkUhXEQSuP3CWdpMwDYksRZbZV3sAullloYE84cVvHYNqYvr0Rh31sNJkdmF5zosrnGqrD9+Tju7GKsbfyc6rpVwXGEfJ44U0qIWuRzj9cvOOveI= Received: from DB7PR05MB4940.eurprd05.prod.outlook.com (20.176.235.152) by DB7PR05MB6201.eurprd05.prod.outlook.com (20.178.107.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.16; Thu, 31 Jan 2019 07:50:16 +0000 Received: from DB7PR05MB4940.eurprd05.prod.outlook.com ([fe80::6161:97fd:d315:7b07]) by DB7PR05MB4940.eurprd05.prod.outlook.com ([fe80::6161:97fd:d315:7b07%6]) with mapi id 15.20.1580.017; Thu, 31 Jan 2019 07:50:16 +0000 From: Ido Schimmel To: Florian Fainelli CC: "netdev@vger.kernel.org" , "andrew@lunn.ch" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , Jiri Pirko , "ilias.apalodimas@linaro.org" , "ivan.khoronzhuk@linaro.org" , "roopa@cumulusnetworks.com" , "nikolay@cumulusnetworks.com" , Petr Machata Subject: Re: [PATCH net-next v2 01/12] net: bridge: multicast: Propagate br_mc_disabled_update() return Thread-Topic: [PATCH net-next v2 01/12] net: bridge: multicast: Propagate br_mc_disabled_update() return Thread-Index: AQHUuDbTGZTTwT43CkGhvsffrrDKnqXHbLkAgAEjsoCAAHJZgA== Date: Thu, 31 Jan 2019 07:50:16 +0000 Message-ID: <20190131075013.GA27839@splinter> References: <20190130005548.2212-1-f.fainelli@gmail.com> <20190130005548.2212-2-f.fainelli@gmail.com> <20190130073656.GA22227@splinter> <63b446c5-8104-d9f9-3924-aaa481ee3b8c@gmail.com> In-Reply-To: <63b446c5-8104-d9f9-3924-aaa481ee3b8c@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P192CA0100.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::41) To DB7PR05MB4940.eurprd05.prod.outlook.com (2603:10a6:10:1e::24) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB7PR05MB6201;6:yff0Db9kDQu14Y/+q2/Tn/9cRjUYP8FSQJHJ4bpzD1ncSqxs7yvvj+t0nwgAg3O3C8AExBNj2TUF/5TjR3pVm5GHCTP/hNj2mkHiGUo6QQia9ZZAo63nJDd2Zj1Clogx4if9lCW3C4QLl4JRgTQ0L6ORaYhNw00deFqf3Wrax8xmLl1OzJYatMfMbQ0EIkgBcu9w6X6t/cS8HPpfgg/CxNaDVTfwsNTXsgosLMj7nGslYR91n+YgdssX5QQnASHQVcn85Cnswp9c5JCeo9PTDKeoG9xwNJ1ztj3TZqD6swOT54PdbmxvmGa9kpBDVyzcX4Qnu3J8+CE7BXvRvncGOoxYBgypl2MU9KlUtzLfFUJVzWsWJ2fv9ccIFklmKzE7N/32rkZEpQGCBiBKenNS65xIvHWCRaRUo1NiBmCAqqau2dwJ1Bdil6LL1VPIhMhp5nk/8gH8mEktlNF9XcoqGg==;5:+qga6Lh5E3i49SDM9UMKz8qHqDlOVa8po5EPG4pzepoN+bJ56aDZ9iuL8Js0uG0cFvVRpgMg28wZTIciejnsOzK16TwDKfv5OmiT54Wt+jHj+c+3aYMlbgbC8qXPoXB+MqXmjFyNXyEHMe7W1mAV75MJgHAKyJuhTHek4RpCgMYym92jPp1jssi7NdD+sSZQ05JY2nvUHMPZlqWoLUEO8w==;7:awzwcykBerTm7p/Xum9fGKIot1UBz0idtAyAXUigefrkGok/Jxi/x+jVx3RyEwQtoKfSfFU/YQNJD38199zkjAtk9g18/9HqN4uUNXkHcHrmAKZtt3GPo0ABC8xLxGBNrkqIH0c+LdI+1hkGlBe1Aw== x-ms-office365-filtering-correlation-id: 7ef950ab-e111-43af-b532-08d68750bd3e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:DB7PR05MB6201; x-ms-traffictypediagnostic: DB7PR05MB6201: x-microsoft-antispam-prvs: x-forefront-prvs: 09347618C4 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(396003)(376002)(366004)(346002)(39860400002)(136003)(189003)(199004)(316002)(97736004)(2906002)(86362001)(229853002)(33896004)(14444005)(8676002)(76176011)(52116002)(66066001)(1076003)(105586002)(8936002)(25786009)(256004)(4326008)(93886005)(106356001)(81156014)(81166006)(54906003)(99286004)(68736007)(102836004)(11346002)(446003)(53936002)(476003)(71190400001)(33656002)(26005)(6506007)(53546011)(478600001)(33716001)(71200400001)(6916009)(386003)(9686003)(6512007)(107886003)(305945005)(486006)(186003)(39060400002)(6486002)(6116002)(7736002)(6436002)(3846002)(14454004)(6246003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR05MB6201;H:DB7PR05MB4940.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /ZFJhPLthwalPInFcv7NGZfRym3Bc3iLFmOgcyQivXdS0+JMptY+gNiM/GN5b+YqFjBIV/jzle6AdOkb56ew4LHsyv2UhNrtrGYJpSwjSzUOUda1Sa4dynL4iGgXu+x/h/okDfUNaeTt0XSywSc60TKyTAnOD1Elc4yHUZCkM0N54NBKY1xfswR4KQZ3DFNu4/LGO2lAeND1JPC0i3WpAX1sVj4rtLG48bnTifInJaRgr6F397/A6TYwXeiQ50QNs/cOwi2AFUhcw3+6FVIhot1KpKAnzEnR3hcrD3zV32JJo8ok6Dcayj69eqebZILt2HXLE9M8naH44UHguXSJCNLpT4FL6LmReUTVhjEmpCDTqIveH6YoolTg9yCdJBgKrlvhYQJpewK9k6gAWL/AhqEym9Qokh72cJvA/rcQ3LU= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ef950ab-e111-43af-b532-08d68750bd3e X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2019 07:50:15.9349 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB6201 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 30, 2019 at 05:00:57PM -0800, Florian Fainelli wrote: > On 1/29/19 11:36 PM, Ido Schimmel wrote: > > On Tue, Jan 29, 2019 at 04:55:37PM -0800, Florian Fainelli wrote: > >> -static void br_mc_disabled_update(struct net_device *dev, bool value) > >> +static int br_mc_disabled_update(struct net_device *dev, bool value) > >> { > >> struct switchdev_attr attr =3D { > >> .orig_dev =3D dev, > >> .id =3D SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED, > >> - .flags =3D SWITCHDEV_F_DEFER, > >> + .flags =3D SWITCHDEV_F_DEFER | SWITCHDEV_F_SKIP_EOPNOTSUPP, > >=20 > > Actually, since the operation is deferred I don't think the return valu= e > > from the driver is ever checked. Can you test it? >=20 > You are right, you get a WARN() from switchdev_attr_port_set_now(), but > this does not propagate back to the caller, so you can still create a > bridge device and enslave a device successfully despite getting warnings > on the console. >=20 > >=20 > > I think it would be good to convert the attributes to use the switchdev > > notifier like commit d17d9f5e5143 ("switchdev: Replace port obj add/del > > SDO with a notification") did for objects. Then you can have your > > listener veto the operation in the same context it is happening. >=20 > Alright, working on it. Would you do that just for the attr_set, or for > attr_get as well (to be symmetrical)? Yes, then we can get rid of switchdev_ops completely.