From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791CEC169C4 for ; Thu, 31 Jan 2019 08:43:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EB9C2087F for ; Thu, 31 Jan 2019 08:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726221AbfAaInK (ORCPT ); Thu, 31 Jan 2019 03:43:10 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41514 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbfAaInJ (ORCPT ); Thu, 31 Jan 2019 03:43:09 -0500 Received: by mail-wr1-f65.google.com with SMTP id x10so2272576wrs.8 for ; Thu, 31 Jan 2019 00:43:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vCqF/oeVcGenWHCg7qQZMMgB4LFazxmElFDVRsEXuNQ=; b=Y9Y4MQozGnDfTeaZgkhVI+2UifhNq2xlT+P/gP1hc8WeWEuen9k+i705eanfHYxcPi Jipll1w3F4o3CtPCPjr4I2QHIS0SY9oIBY++5EsBwMP9CUofKmqdvFKKeyIqCGmso447 BqqxLz8qHx6DYex4z/ort+8GSNY+4a8MJz3plNqrj96b0ly+3YPx5z5blxV2d0iPYQSg obL6U6Nd4/EDESTlya2iG5f5EkPzk2LnEyZpfOIPiWMdrfmeiJHThHI6IyWOIXoKArQd ZRkvy7wCbmdXCrvErC36XVNJuWDQmcyg5WSX9q+80hCkC+eJSeaWVUaQEr2vPaG1zb7l z5bg== X-Gm-Message-State: AJcUukdVNlkDECTUvwvGBts9SbbvmVpAU7xikbEAMSuH+mduwAeztbWP lvSJF37PoHVjBaoongTfndhz5u8tl2I= X-Google-Smtp-Source: ALg8bN7xWsyIbHfap983Rfv+/enyLbTvgAnB968pSnrMbGGikzUCbq0urmeQXczm/l0hGMXAAs/KQw== X-Received: by 2002:a5d:6889:: with SMTP id h9mr33148778wru.222.1548924188063; Thu, 31 Jan 2019 00:43:08 -0800 (PST) Received: from pc-2.home (2a01cb05850ddf00045dd60e6368f84b.ipv6.abo.wanadoo.fr. [2a01:cb05:850d:df00:45d:d60e:6368:f84b]) by smtp.gmail.com with ESMTPSA id o3sm2077881wrs.30.2019.01.31.00.43.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Jan 2019 00:43:07 -0800 (PST) Date: Thu, 31 Jan 2019 09:43:05 +0100 From: Guillaume Nault To: Jacob Wen Cc: netdev@vger.kernel.org Subject: Re: [PATCH net] l2tp: copy 4 more bytes to linear part if necessary Message-ID: <20190131084304.GA22115@pc-2.home> References: <20190131071856.22120-1-jian.w.wen@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131071856.22120-1-jian.w.wen@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 31, 2019 at 03:18:56PM +0800, Jacob Wen wrote: > The size of L2TPv2 header with all optional fields is 14 bytes. > l2tp_udp_recv_core only moves 10 bytes to the linear part of a > skb. This may lead to l2tp_recv_common read data outside of a skb. > Looks good, thanks for taking care of this! Acked-by: Guillaume Nault