From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A724BC169C4 for ; Thu, 31 Jan 2019 17:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F6612086C for ; Thu, 31 Jan 2019 17:25:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="Q53L6IVN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbfAaRZU (ORCPT ); Thu, 31 Jan 2019 12:25:20 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:44379 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725298AbfAaRZU (ORCPT ); Thu, 31 Jan 2019 12:25:20 -0500 Received: by mail-qt1-f193.google.com with SMTP id n32so4280156qte.11 for ; Thu, 31 Jan 2019 09:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=GNCK/aDC5NMGfolKyGMgKfTFmVVis+frtptBhgwCVm0=; b=Q53L6IVNZnI5xMQdTBgohtKErSr7zp1F1vGiXjCliDjt/1gnM9oZ05meyoVmqYbPI5 m9tZFEgTnJNgAnxAHbsn+TjWvMZdZF9M4FUr1M22a07HTbXXCHi3DIxcydsebQH9Wvpv b7pnvNK+OpEvOMYjqByZ+y/TQ/9xk1urnHOHPPbNmSw62/hPnI0Q/rRFZD4bL/GPDfKt ZHaTnWY6FgtZaVTB9MgGl8/nHj4T7+fv46UWp2zmwVQcZARSYSogzLJKJZpUxrT04oAq 6M6xJK1XvyiwhLjwzW9XC4yyleEgUe1ya0ZjZU5P7txCPkemIC2fXxNlTRLUov/1V0mg UO9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=GNCK/aDC5NMGfolKyGMgKfTFmVVis+frtptBhgwCVm0=; b=XXdkeJKT5DlhPBt6v+gyolzv+kqzcZztJhMLUst9M1zVYNoQks+hweuDg7m6rg5Gco IT8FoBTdy17XaBP9Z+bywS8ipuYvM61zVWE1S3yA7llXK2fcp12mDbrk7Hu1lMgDouSZ 4oBnNdxmut3DbkdsM6t9tu+KXuwLUjbli61vHbu4EkVG/w36diTtslucTKtI/UmJIigi 0it7t7joHDVn62jbn+X0MHTEbHDT3JBnRz/Up5GGRHwqUqq3LDmQGM66SLJleWOSgA4v 4JNYaSBAeCuWLNc2F3mGM5bxgFtQ1Fu1a/mQteFO7Dge7/+dxPKrI/CRJEmfmYssV1O8 74Uw== X-Gm-Message-State: AJcUukeae0XuFvmFuZts/zSzXjVRQ98F2sTrLjwFsa0mId2wlAROw9GB 0QTAeTLJrKQNXChAdOWys/ITRA== X-Google-Smtp-Source: ALg8bN4I3ShgpEvNM6lbrQc28UnH+BlLBqYAc5U9lgRPkKKiRUzjYnGe0qztaEV20cf3GTx3NBXzgg== X-Received: by 2002:ac8:96:: with SMTP id c22mr20633383qtg.274.1548955519505; Thu, 31 Jan 2019 09:25:19 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id q5sm11948997qtq.20.2019.01.31.09.25.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Jan 2019 09:25:19 -0800 (PST) Date: Thu, 31 Jan 2019 09:25:08 -0800 From: Jakub Kicinski To: David Miller Cc: lkp@intel.com, kbuild-all@01.org, netdev@vger.kernel.org, oss-drivers@netronome.com, jiri@resnulli.us, andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com Subject: Re: [PATCH net-next v3 8/8] ethtool: add compat for devlink info Message-ID: <20190131092508.53bb519c@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190131.092303.1843359963647606693.davem@davemloft.net> References: <20190130234133.4298-9-jakub.kicinski@netronome.com> <201902010037.2Jsqwihj%fengguang.wu@intel.com> <20190131.092303.1843359963647606693.davem@davemloft.net> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 31 Jan 2019 09:23:03 -0800 (PST), David Miller wrote: > From: kbuild test robot > Date: Fri, 1 Feb 2019 00:19:33 +0800 > > > All errors (new ones prefixed by >>): > > > > m68k-linux-gnu-ld: drivers/rtc/proc.o: in function `is_rtc_hctosys.isra.0': > > proc.c:(.text+0x178): undefined reference to `strcmp' > > m68k-linux-gnu-ld: net/core/ethtool.o: in function `ethtool_get_drvinfo': > >>> ethtool.c:(.text+0xc08): undefined reference to `devlink_compat_running_version' > > Missing string.h include perhaps? Yeah, that one looks like existing m68k bug, but also I think I need to cater to the DEVLINK=m case since ethtool code is always built in we can't use the MAY_USE_DEVLINK trick :S