From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A173C169C4 for ; Thu, 31 Jan 2019 17:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0670E20B1F for ; Thu, 31 Jan 2019 17:29:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="S1Q4pot2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727295AbfAaR3h (ORCPT ); Thu, 31 Jan 2019 12:29:37 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:42244 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbfAaR3h (ORCPT ); Thu, 31 Jan 2019 12:29:37 -0500 Received: by mail-qt1-f196.google.com with SMTP id d19so4308698qtq.9 for ; Thu, 31 Jan 2019 09:29:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=lKGpj6QvaFdF/y587YQNhG3z7YDRrcxnwio3YcZJCXo=; b=S1Q4pot2B6LlY/eb/33zOT2/lgPqGmAz2v5eZ3K+NDYyHJ86qyaTKxZEw3cOtIdFbO KW6FzkyzFM4s97eC/TDHzcZIz8P179ppfcRkOJ13ZJx0GBMVLe6p6zjHWFbqiD6WtfTP 4BKsy+LNVyR6aw7J4TrUlLC/aS1/6mptdb6HsTVooKkpnrXA+w1uzfKVDbU804G8yUq7 MuaWhl+72HMH2CiFz+B4aqWOrojePpVZYS9LAGG0J2AGXt/p7xyecu4vqp6vYYifDUG2 8lBgDkbD2X0L7SlGddQaqZ39aABRCIZf5baofFUEeKFT1HubjI7456kw9I9TOTQv2A02 fgqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=lKGpj6QvaFdF/y587YQNhG3z7YDRrcxnwio3YcZJCXo=; b=AsEQYO+66VsAejcBKbASY5oOqgiYY53IJOCJWY8cy7Qh5O/GNJGDUIdjAlpWA1h2TI bsbLRJGerjw3geDGTAqacjr1/EPPAqXhynL6Et0rP6TglRb6B4CozmPbEGuqvbg05ejS F8nV/8iGYxJSXUQfmhXtsjvCrzcGfUyOt4GRtf4ExrW1M2p+Mls1RUKKEldVJjqsp+kO tjFM31EF0ctPziY2o1SHIJ/4pZn3Jo1bMAxQC3Ul0sQZWaVbb21Luxzu8axih4KEF2Ce pxsvVQnM+NA8XOzDnITf60NX3PSPOBAHpdq3yjCyhjpt+5Jh/ZrQqF5i2bjjaORw2ryg vuow== X-Gm-Message-State: AJcUukdIjALjYpt/UND6b+AW365YMZHRX5O3wOyl5OsNzje4E96IuFyf b4rQZVc+RzLow1RzHOaf6X3QRQ== X-Google-Smtp-Source: ALg8bN6EcBAyvHsNXoIkQpUmvYLxILjiiR99gru3lNodNk/CxIE7IYQ+4K4X79cgY1rYSSXxuvkKHg== X-Received: by 2002:ac8:2b99:: with SMTP id m25mr35055615qtm.36.1548955776347; Thu, 31 Jan 2019 09:29:36 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id 189sm4613049qkh.9.2019.01.31.09.29.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Jan 2019 09:29:36 -0800 (PST) Date: Thu, 31 Jan 2019 09:29:25 -0800 From: Jakub Kicinski To: David Miller Cc: lkp@intel.com, kbuild-all@01.org, netdev@vger.kernel.org, oss-drivers@netronome.com, jiri@resnulli.us, andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com Subject: Re: [PATCH net-next v3 8/8] ethtool: add compat for devlink info Message-ID: <20190131092925.2106513e@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190131092508.53bb519c@cakuba.hsd1.ca.comcast.net> References: <20190130234133.4298-9-jakub.kicinski@netronome.com> <201902010037.2Jsqwihj%fengguang.wu@intel.com> <20190131.092303.1843359963647606693.davem@davemloft.net> <20190131092508.53bb519c@cakuba.hsd1.ca.comcast.net> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 31 Jan 2019 09:25:08 -0800, Jakub Kicinski wrote: > On Thu, 31 Jan 2019 09:23:03 -0800 (PST), David Miller wrote: > > From: kbuild test robot > > Date: Fri, 1 Feb 2019 00:19:33 +0800 > > > > > All errors (new ones prefixed by >>): > > > > > > m68k-linux-gnu-ld: drivers/rtc/proc.o: in function `is_rtc_hctosys.isra.0': > > > proc.c:(.text+0x178): undefined reference to `strcmp' > > > m68k-linux-gnu-ld: net/core/ethtool.o: in function `ethtool_get_drvinfo': > > >>> ethtool.c:(.text+0xc08): undefined reference to `devlink_compat_running_version' > > > > Missing string.h include perhaps? > > Yeah, that one looks like existing m68k bug, but also I think I need to > cater to the DEVLINK=m case since ethtool code is always built in we > can't use the MAY_USE_DEVLINK trick :S I think we have to do this: #if IS_REACHABLE(CONFIG_NET_DEVLINK) void devlink_compat_running_version(struct net_device *dev, char *buf, size_t len); #else static inline void devlink_compat_running_version(struct net_device *dev, char *buf, size_t len) { } #endif Jiri, any objections?