From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C676C169C4 for ; Thu, 31 Jan 2019 12:47:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16BF12086C for ; Thu, 31 Jan 2019 12:47:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733109AbfAaMrA (ORCPT ); Thu, 31 Jan 2019 07:47:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33644 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732650AbfAaMrA (ORCPT ); Thu, 31 Jan 2019 07:47:00 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 40A64C002969; Thu, 31 Jan 2019 12:47:00 +0000 (UTC) Received: from localhost (ovpn-200-19.brq.redhat.com [10.40.200.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AAFFE608C1; Thu, 31 Jan 2019 12:46:57 +0000 (UTC) Date: Thu, 31 Jan 2019 13:46:53 +0100 From: Stefano Brivio To: David Ahern Cc: Phil Sutter , Eric Garver , Tomas Dolezal , Stephen Hemminger , Lennert Buytenhek , netdev@vger.kernel.org Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script Message-ID: <20190131134653.52718677@redhat.com> In-Reply-To: References: <8b930eb8-6ffe-d03f-02a3-12a332edbba3@gmail.com> <20190130115555.61868ab9@redhat.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 31 Jan 2019 12:47:00 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 30 Jan 2019 22:12:45 -0700 David Ahern wrote: > This is a convenience wrapper around commands packaged in iproute2. If > iproute2 adds this wrapper, it will have to carry it and maintain it > forever. Distributions (Fedora, RHEL, Debian, etc) may see it > differently and decide to add this patch onto iproute2 that they > distribute as a means for dropping bridge-utils. That's a reasonable > migration choice. It is just not something upstream iproute2 should carry. I see what you mean now, I didn't think of that. Sure, that also sounds reasonable. I still think this wrapper would require basically zero maintenance, and carrying it would outweigh the burden at large -- and we could also use it as a tool to get users familiar with ip-link and 'bridge' by printing the equivalent syntax before executing the commands. Anyway, I'll inform downstream maintainers about this option. -- Stefano