From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CFA3C169C4 for ; Fri, 1 Feb 2019 00:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 339842084A for ; Fri, 1 Feb 2019 00:33:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="itAAlmSF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727417AbfBAAdK (ORCPT ); Thu, 31 Jan 2019 19:33:10 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:36840 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726976AbfBAAdJ (ORCPT ); Thu, 31 Jan 2019 19:33:09 -0500 Received: by mail-qt1-f195.google.com with SMTP id t13so5680377qtn.3 for ; Thu, 31 Jan 2019 16:33:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=mIXsowvJOsZRxmNEM4gHLA+4SAfRKhc85JsULMYFcdg=; b=itAAlmSFtul0Kq5VLX8CrGhKNx6oUfZM8NvMJW3p6KevSUYZ5Jft9s9axop8Aq5nXq VWZ/QmSYGULKwE8W4qBCt6lRINPt7rIsNlfWWs1YYaBQ1BzhE3Sj07lH/hQsTB5YUUV7 pdy3mtPpbEbyg2x4gENYaBbyF4ed8BTrPHc84dhyH09tGUGjJX4BWYcD+RpUFpQR41CU XdLpPCpjZQl4xf+SwXB9o9gp6F97yfJWGFYtMn7wuS/1orqGVDj/FgM4DNnGgsxxRKQg TejGPw0FiEdrnTqS7096HrTYUmfJU7YJ0iq1ij6/uxCaqRoLLtq80zvujTket1/x+nep VvQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=mIXsowvJOsZRxmNEM4gHLA+4SAfRKhc85JsULMYFcdg=; b=Ic7nYJz03CbvzQKjIbzrfN3/nS+gDOJ3FOP2mMy7Z78vF0jwd/3o8c/Tez7vC4jWOR c6md639JRRFOB3HgqTI46cXlWGEuW1fXxSWqu6E0oDgR+zw3Z9fS/eOBQ3ARba9XHVgV 6i0Ho/UOJSLGXPwB1fUsLer92ZiLP/QzX0Qprl0mnB5GdYtel7uXlO/24ceZ3OvDGziV oEHmYRm+/rHsk4si2Rb0K/9K9EWaurY5KVGY+lcZDxMBKlyEw02sDP55GTaWIzGWFoTe nkbt9LLQEvJ93WTtZnhbmrnxKJDn0lAiG2OS6T4rToUnMN0Onhi1ZTm8nu0eRyLVQ8yR q6xQ== X-Gm-Message-State: AJcUukc497bSjYMEEEllk95bkv6HZjVC556dQCZBk0OROd+TxokMt9X1 r+MoAdtQ3w8JjhzD8Vbe+GxDeORyOP0= X-Google-Smtp-Source: ALg8bN6R4ywGpojQ+szUdNe7jcOkDWLBKR3/p/il27S/tWRAeY+0uYIv/2yiYiKK96rbtRtusvBQIw== X-Received: by 2002:aed:3722:: with SMTP id i31mr37741967qtb.289.1548981188933; Thu, 31 Jan 2019 16:33:08 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id u4sm4748522qkk.51.2019.01.31.16.33.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Jan 2019 16:33:08 -0800 (PST) Date: Thu, 31 Jan 2019 16:32:58 -0800 From: Jakub Kicinski To: Maciej Fijalkowski Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, brouer@redhat.com, john.fastabend@gmail.com Subject: Re: [PATCH bpf-next v5 5/8] xdp: Provide extack messages when prog attachment failed Message-ID: <20190131163258.1633a470@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190201001954.4130-6-maciej.fijalkowski@intel.com> References: <20190201001954.4130-1-maciej.fijalkowski@intel.com> <20190201001954.4130-6-maciej.fijalkowski@intel.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 1 Feb 2019 01:19:51 +0100, Maciej Fijalkowski wrote: > In order to provide more meaningful messages to user when the process of > loading xdp program onto network interface failed, let's add extack > messages within dev_change_xdp_fd. > > Suggested-by: Jakub Kicinski > Signed-off-by: Maciej Fijalkowski Reviewed-by: Jakub Kicinski