From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E611C169C4 for ; Fri, 1 Feb 2019 03:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4528520870 for ; Fri, 1 Feb 2019 03:11:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="KL08dffq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728642AbfBADLP (ORCPT ); Thu, 31 Jan 2019 22:11:15 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:38964 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfBADLO (ORCPT ); Thu, 31 Jan 2019 22:11:14 -0500 Received: by mail-qt1-f194.google.com with SMTP id u47so5966520qtj.6 for ; Thu, 31 Jan 2019 19:11:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=RbyI/EMhhwKZ5hNV8twxcr7uJX4BNEdNfKtKEfCTw3w=; b=KL08dffqiPI3cV+bHdh9yIUCzRiC3oWJgRhS+CeaUhDuvKNQqPJNLoeghPDXPXut2f dY5NbDViPXY0u2jwk25c78TsGWsi7oCtnlY+MJRMXuJ6UoUBMRWV3e7oTVz4k0z00BRU 1ANzTO83W/Ky6B5DZtlvydQei6HyyXXjcuyIzGoSyuTppObod84raHGWCssOEUuRF0pG y/tnaNwtTD+2rFeYCVLzmNruxQeANEzquBwcqVY0kaNvYciTAz74bRN5CnQgzWtO7l1T fpqP1oJn7s4RTnIXlpUl7AQDE6hYXsxkBNQEDVSojkHeO5yJpU2NqXWZhr4eP0kDGZei rnhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=RbyI/EMhhwKZ5hNV8twxcr7uJX4BNEdNfKtKEfCTw3w=; b=jzNoiL3vlCv3VIe9uH06vFnAaBk66tEoxGfxzO59WF1BRB3UGTR73opqrX4n4FPbnX Gvr1IYn8s6IQC/6KGdvSFDH++Pi7qW0Vkl8A3swmCSTBoN6yR73YySxbg8ipaq+61yCC nUoMvUhv8bc6g7S2ahCe1XneRlS+ZHd8E10ChO4ZMU6T7cP4Qffwk+sCFyyNDaNpO785 swnpuf4ZijNxrSc9YfZP3Nxbl3HoJES98kTdH9XZqjq6VctGtonX9dySk+E6BzDzjcpX kcBFJF9a3BJ/GneLF21oMd5i1S0xvAJha9sqz8SIvFzjCXhtVONDY2iugW6VakQj3ChW r0DQ== X-Gm-Message-State: AJcUukdoImx3zcHEh5tiGIfcQLhUavgpm+CQp/vzE+NNueCMKI3VJJNS 0HXY3J3F8gD4MH2mrSv4iTE8xQ== X-Google-Smtp-Source: ALg8bN4z7eV0GEdn4iA1p8jABcuQ007HhNyQ7AkrFS/zEbkX0RTSKHbyr3ACjDfQIDewgWAvX/0wUg== X-Received: by 2002:ac8:22ca:: with SMTP id g10mr37574213qta.105.1548990673541; Thu, 31 Jan 2019 19:11:13 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id y4sm6391981qtc.47.2019.01.31.19.11.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Jan 2019 19:11:13 -0800 (PST) Date: Thu, 31 Jan 2019 19:11:01 -0800 From: Jakub Kicinski To: daniel@iogearbox.net, ast@kernel.org, David Miller Cc: Maciej Fijalkowski , netdev@vger.kernel.org, brouer@redhat.com, john.fastabend@gmail.com, David Ahern Subject: Re: [PATCH bpf-next v5 5/8] xdp: Provide extack messages when prog attachment failed Message-ID: <20190131191101.2e9dc9f6@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190201001954.4130-6-maciej.fijalkowski@intel.com> References: <20190201001954.4130-1-maciej.fijalkowski@intel.com> <20190201001954.4130-6-maciej.fijalkowski@intel.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 1 Feb 2019 01:19:51 +0100, Maciej Fijalkowski wrote: > if (__dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG) || > - __dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG_HW)) > + __dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG_HW)) { > + NL_SET_ERR_MSG(extack, "native and generic XDP can't be active at the same time"); > return -EEXIST; > + } This reminds me, since we allowed native/driver and offloaded XDP programs to coexist in a25717d2b604 ("xdp: support simultaneous driver and hw XDP attachment") I got an internal feature request to also allow generic and native mode. Would anyone object to that? Apart from a touch up to test_offload.py I don't think anything would care. netlink can already carry multiple IDs, iproute2 understands it, too.. (Obviously as a follow up after this set gets merged.)