From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6551DC169C4 for ; Thu, 31 Jan 2019 23:09:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29CEF2087F for ; Thu, 31 Jan 2019 23:09:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="xyqVh+Kg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728032AbfAaXJz (ORCPT ); Thu, 31 Jan 2019 18:09:55 -0500 Received: from mx.aristanetworks.com ([162.210.129.12]:26699 "EHLO prod-mx.aristanetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727933AbfAaXJy (ORCPT ); Thu, 31 Jan 2019 18:09:54 -0500 X-Greylist: delayed 550 seconds by postgrey-1.27 at vger.kernel.org; Thu, 31 Jan 2019 18:09:54 EST Received: from prod-mx.aristanetworks.com (localhost [127.0.0.1]) by prod-mx.aristanetworks.com (Postfix) with ESMTP id 2FE8BD53; Thu, 31 Jan 2019 15:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=Arista-A; t=1548975644; bh=URT4BTEDTJPJKT7Aq+DBOwDta/a0BjYNYLchliKWKTk=; h=From:To:Cc:Subject:Date; b=xyqVh+KgJ6r4M0vU7qvwRyNsXOh6B4ZuJInSFq9qkXr9+HNQHDixwgd7qZHdIFP3q YQq1vSces/ay66rr5AqAu6U2j0vkRPm5Ff0a9YyZ7h/hSCXcf4e/Z3ku2+0aFOVSjz FlafLjvzWmhbW/gntBHBE+inZZX4NN8jazuEhashQ8jkwge5P91uKTvMMIg8M9jsKD XBRWeXOC2B2HtAasnAh7nMzBmEPPik9A3/Upxit5DU5MBsGgRDxWdcTlEfIW4NQJJS WkM6ibMaLFBg3axFUu9Uj380+YWF1Vh/OB4JPsVfZk9TuHwXX1x3Srb64fLwIqHDxf BIu0yFd/nnXmA== Received: from topanga.arista.com.com (unknown [172.20.210.44]) by prod-mx.aristanetworks.com (Postfix) with ESMTP id 22DE2D24; Thu, 31 Jan 2019 15:00:44 -0800 (PST) From: Edward Chron To: davem@davemloft.net Cc: netdev@vger.kernel.org, colona@arista.com, echron@arista.com Subject: [PATCH net-next] ipv4/igmp: Don't drop IGMP pkt with zeros src addr Date: Thu, 31 Jan 2019 15:00:40 -0800 Message-Id: <20190131230040.15232-1-echron@arista.com> X-Mailer: git-send-email 2.17.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Don't drop IGMP packets with a source address of all zeros which are IGMP proxy reports. This is documented in Section 2.1.1 IGMP Forwarding Rules of RFC 4541 IGMP and MLD Snooping Switches Considerations. Signed-off-by: Edward Chron --- net/ipv4/route.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 99be68b15da0..16259ea9df54 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1608,7 +1608,8 @@ int ip_mc_validate_source(struct sk_buff *skb, __be32 daddr, __be32 saddr, return -EINVAL; if (ipv4_is_zeronet(saddr)) { - if (!ipv4_is_local_multicast(daddr)) + if (!ipv4_is_local_multicast(daddr) && + ip_hdr(skb)->protocol != IPPROTO_IGMP) return -EINVAL; } else { err = fib_validate_source(skb, saddr, 0, tos, 0, dev, -- 2.17.2