From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24BEFC282D8 for ; Fri, 1 Feb 2019 17:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F180E21872 for ; Fri, 1 Feb 2019 17:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731557AbfBAR7h (ORCPT ); Fri, 1 Feb 2019 12:59:37 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47270 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729911AbfBAR7h (ORCPT ); Fri, 1 Feb 2019 12:59:37 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 29C3F14261671; Fri, 1 Feb 2019 09:59:36 -0800 (PST) Date: Fri, 01 Feb 2019 09:59:33 -0800 (PST) Message-Id: <20190201.095933.386906135442329993.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: linyunsheng@huawei.com, f.fainelli@gmail.com, wang6495@umn.edu, borisp@mellanox.com, ilyal@mellanox.com, ecree@solarflare.com, mkubecek@suse.cz, ynorov@caviumnetworks.com, jakub.kicinski@netronome.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] ethtool: remove unnecessary check in ethtool_get_regs() From: David Miller In-Reply-To: <20190201082406.GA8459@kadam> References: <20190201082406.GA8459@kadam> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 Feb 2019 09:59:36 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Fri, 1 Feb 2019 11:24:06 +0300 > We recently changed this function in commit f9fc54d313fa ("ethtool: > check the return value of get_regs_len") such that if "reglen" is zero > we return directly. That means we can remove this condition as well. > > Signed-off-by: Dan Carpenter Applied to net-next, thanks.