* [PATCH net-next] net: hns3: Check for allocation failure
@ 2019-02-01 8:32 Dan Carpenter
2019-02-01 18:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-02-01 8:32 UTC (permalink / raw)
To: Yisen Zhuang, liuzhongzhu
Cc: Salil Mehta, David S. Miller, Peng Li, Jian Shen, Huazhong Tan,
Yunsheng Lin, Fuyun Liang, netdev, kernel-janitors
We should return -ENOMEM if the kcalloc() fails.
Fixes: d174ea75c96a ("net: hns3: add statistics for PFC frames and MAC control frame")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index ae8336c18264..afd9a0176923 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -343,6 +343,8 @@ static int hclge_mac_update_stats_complete(struct hclge_dev *hdev, u32 desc_num)
int ret;
desc = kcalloc(desc_num, sizeof(struct hclge_desc), GFP_KERNEL);
+ if (!desc)
+ return -ENOMEM;
hclge_cmd_setup_basic_desc(&desc[0], HCLGE_OPC_STATS_MAC_ALL, true);
ret = hclge_cmd_send(&hdev->hw, desc, desc_num);
if (ret) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: hns3: Check for allocation failure
2019-02-01 8:32 [PATCH net-next] net: hns3: Check for allocation failure Dan Carpenter
@ 2019-02-01 18:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-02-01 18:02 UTC (permalink / raw)
To: dan.carpenter
Cc: yisen.zhuang, liuzhongzhu, salil.mehta, lipeng321, shenjian15,
tanhuazhong, linyunsheng, liangfuyun1, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 1 Feb 2019 11:32:26 +0300
> We should return -ENOMEM if the kcalloc() fails.
>
> Fixes: d174ea75c96a ("net: hns3: add statistics for PFC frames and MAC control frame")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-01 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-01 8:32 [PATCH net-next] net: hns3: Check for allocation failure Dan Carpenter
2019-02-01 18:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).