From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7421C282D8 for ; Fri, 1 Feb 2019 18:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79D7E218FC for ; Fri, 1 Feb 2019 18:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728313AbfBASiO (ORCPT ); Fri, 1 Feb 2019 13:38:14 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47872 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbfBASiO (ORCPT ); Fri, 1 Feb 2019 13:38:14 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 68E52142A39DD; Fri, 1 Feb 2019 10:38:13 -0800 (PST) Date: Fri, 01 Feb 2019 10:38:12 -0800 (PST) Message-Id: <20190201.103812.1527503455899125278.davem@davemloft.net> To: nhorman@tuxdriver.com Cc: marcelo.leitner@gmail.com, lucien.xin@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org Subject: Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out From: David Miller In-Reply-To: <20190201123118.GA5970@hmswarspite.think-freely.org> References: <1689af9c618.2807.d241da8dbb85b87157d6a44ac288e71f@tuxdriver.com> <20190201003941.GD10665@localhost.localdomain> <20190201123118.GA5970@hmswarspite.think-freely.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 Feb 2019 10:38:13 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Neil Horman Date: Fri, 1 Feb 2019 07:31:18 -0500 > On Thu, Jan 31, 2019 at 10:39:41PM -0200, Marcelo Ricardo Leitner wrote: >> On Tue, Jan 29, 2019 at 07:58:07PM +0100, Tuxdriver wrote: >> > I was initially under the impression that with Kent's repost, the radixtree >> > (which is what I think you meant by rhashtables) updates would be merged >> >> Oops! Yep.. I had meant flex_arrays actually. >> >> > imminently, but that doesn't seem to be the case. I'd really like to know >> > what the hold up there is, as that patch seems to have been stalled for >> > months. I hate the notion of breaking the radixtree patch, but if it's >> > status is indeterminate, then, yes, we probably need to go with xins patch >> > for the short term, and let Kent fix it up in due course. >> >> Dave, can you please consider applying this patch? The conflict >> resolution will be easy: just ignore the changes introduced by this >> patch. >> > Dave I concur with Marcelo here. Kent was very active in getting sctp fixed up > to use radixtrees, but now he seems to have gone to ground, and for whatever > reason, no one seems interested in incorporating his patch. Its been languising > for months, so I think we need to take action to secure sctp now until such time > as his genradix changes finally move forward. I agree, please let's get this sctp patch resubmitted and back into patchwork and I will apply it.