From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=fpHc=QI=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1A597C282D8
	for <netdev@archiver.kernel.org>; Fri,  1 Feb 2019 23:36:42 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id D8FC121872
	for <netdev@archiver.kernel.org>; Fri,  1 Feb 2019 23:36:41 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726422AbfBAXgk (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 1 Feb 2019 18:36:40 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:51492 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725803AbfBAXgk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 1 Feb 2019 18:36:40 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 0DE96144A0100;
        Fri,  1 Feb 2019 15:36:39 -0800 (PST)
Date:   Fri, 01 Feb 2019 15:36:38 -0800 (PST)
Message-Id: <20190201.153638.647120007389173035.davem@davemloft.net>
To:     jakub.kicinski@netronome.com
Cc:     netdev@vger.kernel.org, oss-drivers@netronome.com,
        jiri@resnulli.us, andrew@lunn.ch, f.fainelli@gmail.com,
        mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com
Subject: Re: [PATCH net-next v4 0/8] devlink: add device (driver)
 information API
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190131185047.27685-1-jakub.kicinski@netronome.com>
References: <20190131185047.27685-1-jakub.kicinski@netronome.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 Feb 2019 15:36:39 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 31 Jan 2019 10:50:39 -0800

> fw_version field in ethtool -i does not suit modern needs with 31
> characters being quite limiting on more complex systems.  There is
> also no distinction between the running and flashed versions of
> the firmware.
> 
> Since the driver information pertains to the entire device, rather
> than a particular netdev, it seems wise to move it do devlink, at
> the same time fixing the aforementioned issues.
> 
> The new API allows exposing the device serial number and versions
> of the components of the card - both hardware, firmware (running
> and flashed).  Driver authors can choose descriptive identifiers
> for the version fields.  A few version identifiers which seemed
> relevant for most devices have been added to the global devlink
> header.
> 
> Example:
 ...
> Last patch also includes a compat code for ethtool.  If driver
> reports no fw_version via the traditional ethtool API, ethtool
> can call into devlink and try to cram as many versions as possible
> into the 31 characters.
 ...

Series applied.