From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C5DC282D8 for ; Fri, 1 Feb 2019 08:06:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 488A320863 for ; Fri, 1 Feb 2019 08:06:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="1zcWp1Cm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727935AbfBAIGU (ORCPT ); Fri, 1 Feb 2019 03:06:20 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40921 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbfBAIGT (ORCPT ); Fri, 1 Feb 2019 03:06:19 -0500 Received: by mail-wr1-f66.google.com with SMTP id p4so6005894wrt.7 for ; Fri, 01 Feb 2019 00:06:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yfBjTk7N8smU2EB6JJuE5DMPV47UGl7nAQnFqXsxD4I=; b=1zcWp1CmyPjYmcfiwQD0TrDIx/gUgTjH6kF1pTw8GAXBG7Gs1GcG7EW4lPRQTYO5rw RyJComLIGtS1HeDrPYDvXQyfaLYewWuxGigtORJI5zPHUzlYkhmBEcg7PGGceaHlKUAI 5YQ2GyU3Hm9UqPxmsQmbR0fSV0zwSt4gGWgafzTgSZkxOFL5TVzcoxwAWjQDXKthZ37H Z8lzjuFPkU36hv7sF/fKYO1c+q5kL9zauTiOWvb5kMSwIxzV8tsHjGsrAfzG89l4q0v1 EeN6XAfA/3tCeJzm6Q3GGDHiroyst9oDPg0f5eaKgCrGqxn0488Iu0Bs3zE4VbhMKTUN ZAzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yfBjTk7N8smU2EB6JJuE5DMPV47UGl7nAQnFqXsxD4I=; b=ZD8NI1OooRghsJZXOl6yGXtSLhs/qjiF8ldOfRYL9hOIxyNkyOXb/pb4hneUeX97tc a7AY+b4k1ZmvNoBkTLmrYtHar69A796rgnaDOMNOqVMTEhsQTM6qcQRmaCF6TwjWReqe 78OPHI+1xscKyERbvmGNwaMoSPmWecqMnAsp58gl0otbz2LdOdbWc2qH3ruckh11gmz9 vkXLM8R4L1Kh7vrATcAIP3TkkKCWJEqfvw0v1ARFsJ78qMsqQO+/XoX38hADMmFIFYdM 7/+SZov/67qXl6uG0rnhtwU0v5pxNaypPBAz78V3/wQhdvjIjwUkvYYb9bj9EwP9PUUA eYJg== X-Gm-Message-State: AJcUukfyWABAg9Ew9JIIvQvSMqBlhzZQXsSjtWhIQRUi2xveCHAwoha/ o4nT2m1psGR/4u6aJ8CDoJO6Gg== X-Google-Smtp-Source: ALg8bN6o2gUHv0pk+8/ctJ1K6ZyIEsz2WOYz1aZw9wRVlTs4YSBQ2130QG8O/oW95bjs96j0FGo21w== X-Received: by 2002:adf:91a3:: with SMTP id 32mr33991929wri.99.1549008378005; Fri, 01 Feb 2019 00:06:18 -0800 (PST) Received: from localhost (ip-89-102-138-152.net.upcbroadband.cz. [89.102.138.152]) by smtp.gmail.com with ESMTPSA id p10sm5223128wmd.14.2019.02.01.00.06.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Feb 2019 00:06:17 -0800 (PST) Date: Fri, 1 Feb 2019 08:57:14 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: David Miller , lkp@intel.com, kbuild-all@01.org, netdev@vger.kernel.org, oss-drivers@netronome.com, andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com Subject: Re: [PATCH net-next v3 8/8] ethtool: add compat for devlink info Message-ID: <20190201075714.GA2401@nanopsycho> References: <20190130234133.4298-9-jakub.kicinski@netronome.com> <201902010037.2Jsqwihj%fengguang.wu@intel.com> <20190131.092303.1843359963647606693.davem@davemloft.net> <20190131092508.53bb519c@cakuba.hsd1.ca.comcast.net> <20190131092925.2106513e@cakuba.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131092925.2106513e@cakuba.hsd1.ca.comcast.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Jan 31, 2019 at 06:29:25PM CET, jakub.kicinski@netronome.com wrote: >On Thu, 31 Jan 2019 09:25:08 -0800, Jakub Kicinski wrote: >> On Thu, 31 Jan 2019 09:23:03 -0800 (PST), David Miller wrote: >> > From: kbuild test robot >> > Date: Fri, 1 Feb 2019 00:19:33 +0800 >> > >> > > All errors (new ones prefixed by >>): >> > > >> > > m68k-linux-gnu-ld: drivers/rtc/proc.o: in function `is_rtc_hctosys.isra.0': >> > > proc.c:(.text+0x178): undefined reference to `strcmp' >> > > m68k-linux-gnu-ld: net/core/ethtool.o: in function `ethtool_get_drvinfo': >> > >>> ethtool.c:(.text+0xc08): undefined reference to `devlink_compat_running_version' >> > >> > Missing string.h include perhaps? >> >> Yeah, that one looks like existing m68k bug, but also I think I need to >> cater to the DEVLINK=m case since ethtool code is always built in we >> can't use the MAY_USE_DEVLINK trick :S > >I think we have to do this: > >#if IS_REACHABLE(CONFIG_NET_DEVLINK) >void devlink_compat_running_version(struct net_device *dev, > char *buf, size_t len); >#else >static inline void >devlink_compat_running_version(struct net_device *dev, char *buf, size_t len) >{ >} >#endif > >Jiri, any objections? Np.