From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEC7C282D8 for ; Fri, 1 Feb 2019 08:07:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A068121726 for ; Fri, 1 Feb 2019 08:07:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="OhUNDHPE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbfBAIHH (ORCPT ); Fri, 1 Feb 2019 03:07:07 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39971 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbfBAIHH (ORCPT ); Fri, 1 Feb 2019 03:07:07 -0500 Received: by mail-wr1-f68.google.com with SMTP id p4so6008180wrt.7 for ; Fri, 01 Feb 2019 00:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YsoFIxA3gp/lXENDqaQq5NTGTQLAi6ymaWdi39xADto=; b=OhUNDHPEvWY6XlLedx1PlLRDPDpINV7KLIMXh+y6B+ojL4Z7Nqp/e0zdGac6VWQ1aV HN2i8BT16MmhGp6lNGciBqMIy9PyPTEKaJVAWEOQujeZcCvt2jV2/dMh7iLbhVkw4nex Bmn9PDt4PaqmaG0EVFk+HOKxoXvpD5KPttpWFqA2PmI0BxpflwVo2AYFKgN3szpqdFH2 TwrMRAv4z2cdcv3ZoR2dChPjat0hv5+akaj7hWruseo7LLrXbzyVaSL+kCD8oQz17N48 04cXl6cMv/WmtCl1ttG3vM4vrNP+tmvZJ+V6hjkHyYg3k9Hm474GPLAVT3tSTo+KCXC7 wKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YsoFIxA3gp/lXENDqaQq5NTGTQLAi6ymaWdi39xADto=; b=t0sGsfc0zClQFAR8QtahJiMLtCuOOnTDQrFMaetFQXuvieGG1W/iXceNEqLjEsY9Bd bZ2h1zZ2/bTDDKT6MI0s1l7el2545hp11l+EcMq83ZGFYb2MxwICu4Bt03WZL4xBmLt+ 2Gu/xS5d/U/ue0w+jf/jtxsAhQCTPGbCOWMDVNsIu2Ls7CPhVnGjiyKyIOdplwjgI9/y 9KwNdI/6f1tcLsrilrZ+7YE3sOUycx1LQNhD0rkGfoSx82Pnha9E1o9ldPSbvnMYl+LT Fu6JSZ4jh/vuuBhkBUcZUz2osNY0UoH6GgQYksS+dtt1gb/xGd2XTvHppLhPve0nX54Z AKIg== X-Gm-Message-State: AJcUukd4wLinPJ2L6QssiTrJKlViE9FKRCWbzQAyMd3ACOFrUINjT8bY CA/mXY5ZbS9U3WqNJSnl5QkYZg== X-Google-Smtp-Source: ALg8bN7OwY+NvQF8tBmrBmAuhTZUcClbe7tvUIlBYG5Lt5iC3HaTktdXUO5XJpwgQ+ESvZe471Aejg== X-Received: by 2002:adf:e54a:: with SMTP id z10mr36541654wrm.238.1549008425559; Fri, 01 Feb 2019 00:07:05 -0800 (PST) Received: from localhost (ip-89-102-138-152.net.upcbroadband.cz. [89.102.138.152]) by smtp.gmail.com with ESMTPSA id f2sm7369780wru.14.2019.02.01.00.07.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Feb 2019 00:07:05 -0800 (PST) Date: Fri, 1 Feb 2019 08:58:02 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz, eugenem@fb.com, jonathan.lemon@gmail.com Subject: Re: [PATCH net-next v4 8/8] ethtool: add compat for devlink info Message-ID: <20190201075802.GB2401@nanopsycho> References: <20190131185047.27685-1-jakub.kicinski@netronome.com> <20190131185047.27685-9-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131185047.27685-9-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Jan 31, 2019 at 07:50:47PM CET, jakub.kicinski@netronome.com wrote: >If driver did not fill the fw_version field, try to call into >the new devlink get_info op and collect the versions that way. >We assume ethtool was always reporting running versions. > >v4: > - use IS_REACHABLE() to avoid problems with DEVLINK=m (kbuildbot). >v3 (Jiri): > - do a dump and then parse it instead of special handling; > - concatenate all versions (well, all that fit :)). > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko