From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7BE7C282D8 for ; Fri, 1 Feb 2019 21:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B63D62148D for ; Fri, 1 Feb 2019 21:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="i4JKnknR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726619AbfBAVrw (ORCPT ); Fri, 1 Feb 2019 16:47:52 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40813 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726449AbfBAVrw (ORCPT ); Fri, 1 Feb 2019 16:47:52 -0500 Received: by mail-pf1-f196.google.com with SMTP id i12so3858410pfo.7 for ; Fri, 01 Feb 2019 13:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=thrrDGLer70LoGS8afuvwcWRAdQfaF6Oql27O9ZsFX8=; b=i4JKnknRbUggbr58rkAWu9NOIHguNxScQP1z6xiFEXAfTtW22T1J7QmWiCaLd+5oRm g/IoeQOR7fRhxWXH+5cfZF53+fo4OOVO/OFtfTea7CCkzl9xKFvmUBs4NuBTpNVZbXsv av0KZtNyVyKnTjBvELxo2JAq1rvewAitnKXQUahYaAytJY01FBxg8DaFftPU/J1bTtju TL1L7vqxZr+lUggfozcNyRYjvGfB2zGib64Ly7qPTItk/AiDDFvUWyDQ7QkbeC6sxwBD K/ilIpmrIOsA4bdMZ99iNsCb1G9Mysy50FLMY7+voVK4ITWqhVE1cuo2VGb3aER3BFaF eT7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=thrrDGLer70LoGS8afuvwcWRAdQfaF6Oql27O9ZsFX8=; b=lACVYjfxKIrLeKD40f/SOJrmfQLegNklkPfwgcwkncKCZV0MusoFfaMqpLpOKcT0Ei OXDiZ1Oa+GLw2hXyn0e4wZNvorvXGaxJI/YV8W/4mEXzAiQBwc7BLd4MoU0JVjHnGoO5 jPJhBSoD0or2Zr8V9sZfVu2ztD6nhfMKXgH8yjTNdWWopkdRVH5fJ5U3JIvaJVz79u9u EM2PzMpIpg8v+rqC/bX4iR2ton09WjLYl4U1dAXmW6OE8OG7Y6EDPH7na9YbFsC4Wn89 0BDBqBl6te5anE5wxhvaawqrt5qzoIuDq4RL3OASlL7H/HuYXI28sidCTNnqTZnyIYl/ DNOg== X-Gm-Message-State: AHQUAubkRT6K8ONtnAEgLkmuBeqMEcOue7pCIkjMdAXe+mYt3VtK85V7 AZ1npgwdvbBzGiqG6X71iF+yUw== X-Google-Smtp-Source: AHgI3IY/uxKku85ET4updCrINBl/Fm6ejLi0t2l2d2CCzaV1hI4C89kuRss9o24wQ3TcWEvp1ICOZQ== X-Received: by 2002:a63:f141:: with SMTP id o1mr3964150pgk.134.1549057671247; Fri, 01 Feb 2019 13:47:51 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id m67sm11882559pfm.73.2019.02.01.13.47.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Feb 2019 13:47:51 -0800 (PST) Date: Fri, 1 Feb 2019 13:47:46 -0800 From: Jakub Kicinski To: Daniel Borkmann Cc: Maciej Fijalkowski , ast@kernel.org, netdev@vger.kernel.org, brouer@redhat.com, john.fastabend@gmail.com Subject: Re: [PATCH bpf-next v5 7/8] libbpf: Add a support for getting xdp prog id on ifindex Message-ID: <20190201134746.59386942@cakuba.hsd1.ca.comcast.net> In-Reply-To: <5d963a81-6a22-b1c6-e2f6-b6734c6d78ff@iogearbox.net> References: <20190201001954.4130-1-maciej.fijalkowski@intel.com> <20190201001954.4130-8-maciej.fijalkowski@intel.com> <5d963a81-6a22-b1c6-e2f6-b6734c6d78ff@iogearbox.net> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 1 Feb 2019 22:43:39 +0100, Daniel Borkmann wrote: > On 02/01/2019 01:19 AM, Maciej Fijalkowski wrote: > > Since we have a dedicated netlink attributes for xdp setup on a > > particular interface, it is now possible to retrieve the program id that > > is currently attached to the interface. The use case is targeted for > > sample xdp programs, which will store the program id just after loading > > bpf program onto iface. On shutdown, the sample will make sure that it > > can unload the program by querying again the iface and verifying that > > both program id's matches. > > > > Signed-off-by: Maciej Fijalkowski > > Reviewed-by: Jakub Kicinski > [...] > > +int bpf_get_link_xdp_id(int ifindex, __u32 *prog_id, __u32 flags) > > +{ > > + struct xdp_id_md xdp_id = {}; > > + int sock, ret; > > + __u32 nl_pid; > > + __u32 mask; > > + > > + if (flags & ~XDP_FLAGS_MASK) > > + return -EINVAL; > > + > > + /* Check whether the single {HW,DRV,SKB} mode is set */ > > + flags &= (XDP_FLAGS_SKB_MODE | XDP_FLAGS_DRV_MODE | XDP_FLAGS_HW_MODE); > > + mask = flags - 1; > > + if (flags && flags & mask) > > + return -EINVAL; > > + > > + sock = libbpf_netlink_open(&nl_pid); > > + if (sock < 0) > > + return sock; > > + > > + xdp_id.ifindex = ifindex; > > + xdp_id.flags = flags; > > + > > + ret = libbpf_nl_get_link(sock, nl_pid, get_xdp_id, &xdp_id); > > + if (!ret) > > + *prog_id = xdp_id.id; > > + > > + close(sock); > > + return ret; > > +} > > Btw, is anyone going to follow-up on XDP_ATTACHED_MULTI support as well > later on? I haven't tested to be honest, but I think Maciek got that right - get_xdp_id_attr() should return IFLA_XDP_PROG_ID or a mode-specific attr based on flags. And there is a check that only flag is set. Or do you mean retrieving all program ids with one dump?