From: Yonghong Song <yhs@fb.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>,
Magnus Karlsson <magnus.karlsson@intel.com>,
<netdev@vger.kernel.org>
Cc: Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>,
Yonghong Song <yhs@fb.com>
Subject: [PATCH bpf-next v2 0/3] tools/bpf: changes of libbpf debug interfaces
Date: Fri, 1 Feb 2019 09:47:31 -0800 [thread overview]
Message-ID: <20190201174731.695459-1-yhs@fb.com> (raw)
These are patches responding to my comments for
Magnus's patch (https://patchwork.ozlabs.org/patch/1032848/).
The goal is to make pr_* macros available to other C files
than libbpf.c, and to simplify API function libbpf_set_print().
Specifically, Patch #1 used global functions
to facilitate pr_* macros in the header files so they
are available in different C files.
Patch #2 removes the global function libbpf_dprint_level_available()
which is added in Patch 1.
Patch #3 simplified libbpf_set_print() which takes only one print
function with a debug level argument among others.
Changelogs:
v1 -> v2:
. Renamed global function libbpf_dprint() to libbpf_debug_print()
to be more expressive.
. Removed libbpf_dprint_level_available() as it is used only
once in btf.c and we can remove it by optimizing for common cases.
Yonghong Song (3):
tools/bpf: move libbpf pr_* debug print functions to headers
tools/bpf: print out btf log at LIBBPF_WARN level
tools/bpf: simplify libbpf API function libbpf_set_print()
tools/lib/bpf/btf.c | 110 +++++++++---------
tools/lib/bpf/btf.h | 7 +-
tools/lib/bpf/libbpf.c | 42 +++----
tools/lib/bpf/libbpf.h | 20 ++--
tools/lib/bpf/test_libbpf.cpp | 4 +-
tools/lib/bpf/util.h | 30 +++++
tools/perf/util/bpf-loader.c | 32 ++---
tools/testing/selftests/bpf/test_btf.c | 7 +-
.../testing/selftests/bpf/test_libbpf_open.c | 36 +++---
tools/testing/selftests/bpf/test_progs.c | 20 +++-
10 files changed, 166 insertions(+), 142 deletions(-)
create mode 100644 tools/lib/bpf/util.h
--
2.17.1
next reply other threads:[~2019-02-01 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 17:47 Yonghong Song [this message]
2019-02-01 17:47 ` [PATCH bpf-next v2 1/3] tools/bpf: move libbpf pr_* debug print functions to headers Yonghong Song
2019-02-01 23:10 ` Arnaldo Carvalho de Melo
2019-02-01 23:20 ` Yonghong Song
2019-02-01 23:29 ` Arnaldo Carvalho de Melo
2019-02-01 17:47 ` [PATCH bpf-next v2 2/3] tools/bpf: print out btf log at LIBBPF_WARN level Yonghong Song
2019-02-01 17:47 ` [PATCH bpf-next v2 3/3] tools/bpf: simplify libbpf API function libbpf_set_print() Yonghong Song
2019-02-01 19:02 ` Andrii Nakryiko
2019-02-01 20:37 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201174731.695459-1-yhs@fb.com \
--to=yhs@fb.com \
--cc=acme@redhat.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).