From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A49E8C282D8 for ; Fri, 1 Feb 2019 21:15:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 643362146E for ; Fri, 1 Feb 2019 21:15:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="VBTS3MFk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726067AbfBAVPy (ORCPT ); Fri, 1 Feb 2019 16:15:54 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:36206 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfBAVPy (ORCPT ); Fri, 1 Feb 2019 16:15:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/va5COFy1u3Y60Elgvt9WJkYbbrjL1yV58Q2OfrMahg=; b=VBTS3MFkBuyft3I2FlivY28/QM ndXmpd9tgwkHdWSVr2M9eeb1BkKWEe0H869iMwspxdgxalt6wnYXVz/9w3V5jgwYKfEXYxmseTaRl My6krCRnmGP9sfGXe+45pDFZ1Qn+R0+YIGr8N01PKJeWn9t7aAK9p1E23RILYIuVFNMI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gpgAB-0003TV-0f; Fri, 01 Feb 2019 22:15:51 +0100 Date: Fri, 1 Feb 2019 22:15:51 +0100 From: Andrew Lunn To: Sebastian Andrzej Siewior Cc: Richard Cochran , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org Subject: Re: [PATCH v2] net: dp83640: expire old TX-skb Message-ID: <20190201211551.GD8274@lunn.ch> References: <20190201210918.gvufqxpqzvuzfk5n@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190201210918.gvufqxpqzvuzfk5n@linutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 01, 2019 at 10:09:18PM +0100, Sebastian Andrzej Siewior wrote: > During sendmsg() a cloned skb is saved via dp83640_txtstamp() in > ->tx_queue. After the NIC sends this packet, the PHY will reply with a > timestamp for that TX packet. If the cable is pulled at the right time I > don't see that packet. It might gets flushed as part of queue shutdown > on NIC's side. > Once the link is up again then after the next sendmsg() we enqueue > another skb in dp83640_txtstamp() and have two on the list. Then the PHY > will send a reply and decode_txts() attaches it to the first skb on the > list. > No crash occurs since refcounting works but we are one packet behind. > linuxptp/ptp4l usually closes the socket and opens a new one (in such a > timeout case) so those "stale" replies never get there. However it does > not resume normal operation anymore. > > Purge old skbs in decode_txts(). > > Cc: stable@vger.kernel.org > Signed-off-by: Sebastian Andrzej Siewior > Reviewed-by: Kurt Kanzenbach Hi Sebastian netdev does not use the Cc: stable@vger.kernel.org. https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt Please include a Fixes: tag, and a subject of [PATCH net] ... Thanks Andrew