From: Maciej Fijalkowski <maciejromanfijalkowski@gmail.com>
To: daniel@iogearbox.net, ast@kernel.org
Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com,
brouer@redhat.com, john.fastabend@gmail.com
Subject: [PATCH bpf-next v6 2/8] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe
Date: Fri, 1 Feb 2019 22:42:24 +0100 [thread overview]
Message-ID: <20190201214230.1441-3-maciej.fijalkowski@intel.com> (raw)
In-Reply-To: <20190201214230.1441-1-maciej.fijalkowski@intel.com>
From: Jesper Dangaard Brouer <brouer@redhat.com>
The sample xdp_redirect_cpu is not using helper bpf_trace_printk.
Thus it makes no sense that the --debug option us reading
from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe.
Simply remove it.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
---
samples/bpf/xdp_redirect_cpu_user.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/samples/bpf/xdp_redirect_cpu_user.c b/samples/bpf/xdp_redirect_cpu_user.c
index 2d23054aaccf..f141e752ca0a 100644
--- a/samples/bpf/xdp_redirect_cpu_user.c
+++ b/samples/bpf/xdp_redirect_cpu_user.c
@@ -51,7 +51,6 @@ static const struct option long_options[] = {
{"help", no_argument, NULL, 'h' },
{"dev", required_argument, NULL, 'd' },
{"skb-mode", no_argument, NULL, 'S' },
- {"debug", no_argument, NULL, 'D' },
{"sec", required_argument, NULL, 's' },
{"prognum", required_argument, NULL, 'p' },
{"qsize", required_argument, NULL, 'q' },
@@ -563,7 +562,6 @@ int main(int argc, char **argv)
bool use_separators = true;
bool stress_mode = false;
char filename[256];
- bool debug = false;
int added_cpus = 0;
int longindex = 0;
int interval = 2;
@@ -624,9 +622,6 @@ int main(int argc, char **argv)
case 'S':
xdp_flags |= XDP_FLAGS_SKB_MODE;
break;
- case 'D':
- debug = true;
- break;
case 'x':
stress_mode = true;
break;
@@ -688,11 +683,6 @@ int main(int argc, char **argv)
return EXIT_FAIL_XDP;
}
- if (debug) {
- printf("Debug-mode reading trace pipe (fix #define DEBUG)\n");
- read_trace_pipe();
- }
-
stats_poll(interval, use_separators, prog_num, stress_mode);
return EXIT_OK;
}
--
2.16.1
next prev parent reply other threads:[~2019-02-01 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 21:42 [PATCH bpf-next v6 0/8] xdp: Avoid unloading xdp prog not attached by sample Maciej Fijalkowski
2019-02-01 21:42 ` [PATCH bpf-next v6 1/8] libbpf: Add a helper for retrieving a map fd for a given name Maciej Fijalkowski
2019-02-01 21:42 ` Maciej Fijalkowski [this message]
2019-02-01 21:42 ` [PATCH bpf-next v6 3/8] samples/bpf: Convert XDP samples to libbpf usage Maciej Fijalkowski
2019-02-01 21:42 ` [PATCH bpf-next v6 4/8] samples/bpf: Extend RLIMIT_MEMLOCK for xdp_{sample_pkts, router_ipv4} Maciej Fijalkowski
2019-02-01 21:42 ` [PATCH bpf-next v6 5/8] xdp: Provide extack messages when prog attachment failed Maciej Fijalkowski
2019-02-01 21:42 ` [PATCH bpf-next v6 6/8] samples/bpf: Add a "force" flag to XDP samples Maciej Fijalkowski
2019-02-01 21:42 ` [PATCH bpf-next v6 7/8] libbpf: Add a support for getting xdp prog id on ifindex Maciej Fijalkowski
2019-02-01 21:42 ` [PATCH bpf-next v6 8/8] samples/bpf: Check the prog id before exiting Maciej Fijalkowski
2019-02-01 22:46 ` [PATCH bpf-next v6 0/8] xdp: Avoid unloading xdp prog not attached by sample Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201214230.1441-3-maciej.fijalkowski@intel.com \
--to=maciejromanfijalkowski@gmail.com \
--cc=ast@kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).