From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A13F5C282D8 for ; Fri, 1 Feb 2019 23:29:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63AFC218AC for ; Fri, 1 Feb 2019 23:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549063783; bh=5NEV8AxYrxkcRfZqGT/guKfS0bfUB+DSunqITzcTvqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vufsjhM0zVvV7J+o8gFika3jUpLcdGv9sgl/FbqOaZvfhQsZitvdDWw6YLHZB00Dn wwheS01vKmkESaNbuFi4Z0gISAd6LfTzaQMas6dJzjmRCGEw02KhiPw4gE5zn4ovv+ UEgrBhIG+yxW5nPgb9RUZuBH2rNU1DT3ufcZXtbc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727368AbfBAX3m (ORCPT ); Fri, 1 Feb 2019 18:29:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:57676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbfBAX3m (ORCPT ); Fri, 1 Feb 2019 18:29:42 -0500 Received: from quaco.ghostprotocols.net (unknown [94.113.247.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C17B21872; Fri, 1 Feb 2019 23:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549063781; bh=5NEV8AxYrxkcRfZqGT/guKfS0bfUB+DSunqITzcTvqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FrTc7Qer9MtwIsUl78GSkUy8QV2tdSUQsCfcnf83zTHLjwncjqBCXNexO/T/PqCIn f8LsMhpK6oZRvgm26DlVbBrWiB1kh3jVCXkMLGP+qxVVIDv7eeryojAyVR6HCZxMHJ Yqvz7ML0TSaksjmbUVhynDfnxCcla5qJjmfD277Y= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id B0DCE4034F; Sat, 2 Feb 2019 00:29:38 +0100 (CET) Date: Sat, 2 Feb 2019 00:29:38 +0100 From: Arnaldo Carvalho de Melo To: Yonghong Song Cc: Arnaldo Carvalho de Melo , Magnus Karlsson , "netdev@vger.kernel.org" , Alexei Starovoitov , Daniel Borkmann , Kernel Team Subject: Re: [PATCH bpf-next v2 1/3] tools/bpf: move libbpf pr_* debug print functions to headers Message-ID: <20190201232938.GC5593@kernel.org> References: <20190201174731.695459-1-yhs@fb.com> <20190201174731.695515-1-yhs@fb.com> <20190201231007.GB5593@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Em Fri, Feb 01, 2019 at 11:20:44PM +0000, Yonghong Song escreveu: > On 2/1/19 3:10 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 01, 2019 at 09:47:31AM -0800, Yonghong Song escreveu: > >> @@ -698,13 +695,13 @@ struct btf_ext *btf_ext__new(__u8 *data, __u32 size, btf_print_fn_t err_log) > >> if (!btf_ext) > >> return ERR_PTR(-ENOMEM); > >> > >> - err = btf_ext_copy_func_info(btf_ext, data, size, err_log); > >> + err = btf_ext_copy_func_info(btf_ext, data, size); > >> if (err) { > >> btf_ext__free(btf_ext); > > > > One thing I noticed whas that the class + __ + method is not being > > consistently followed, will this be dealt with in a followup patch, i.e. > > to make this consistently use the format used in the > > btf_ext__free(btf_ext) case? > > Currently, the API functions have both +_+ and +__+ method names. > The +_+ is for APIs having a close one-to-one mapping > to system calls. The +__+ is for APIs a little bit high level. > Did you find any particular method whose format is not quite right? Nope, and thanks for the clarification, if I find something else I'll get in touch, - Arnaldo