* [PATCH bpf-next] selftests/bpf: remove generated verifier/tests.h on 'make clean'
@ 2019-02-01 23:46 Stanislav Fomichev
2019-02-01 23:47 ` Jakub Kicinski
2019-02-02 6:16 ` Y Song
0 siblings, 2 replies; 4+ messages in thread
From: Stanislav Fomichev @ 2019-02-01 23:46 UTC (permalink / raw)
To: netdev
Cc: davem, ast, daniel, jakub.kicinski, quentin.monnet,
Stanislav Fomichev
'make clean' is supposed to remove generated files.
Signed-off-by: Stanislav Fomichev <sdf@google.com>
---
tools/testing/selftests/bpf/Makefile | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index 8993e9c8f410..858572490644 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -216,7 +216,8 @@ ifeq ($(DWARF2BTF),y)
$(BTF_PAHOLE) -J $@
endif
-$(OUTPUT)/test_verifier: $(OUTPUT)/verifier/tests.h
+VERIFIER_TESTS_H := $(OUTPUT)/verifier/tests.h
+$(OUTPUT)/test_verifier: $(VERIFIER_TESTS_H)
$(OUTPUT)/test_verifier: CFLAGS += -I$(OUTPUT)
VERIFIER_TEST_FILES := $(wildcard verifier/*.c)
@@ -227,6 +228,7 @@ $(OUTPUT)/verifier/tests.h: $(VERIFIER_TEST_FILES)
ls *.c 2> /dev/null | \
sed -e 's@\(.*\)@#include \"\1\"@'; \
echo '#endif' \
- ) > $(OUTPUT)/verifier/tests.h)
+ ) > $(VERIFIER_TESTS_H))
-EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(ALU32_BUILD_DIR)
+EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(ALU32_BUILD_DIR) \
+ $(VERIFIER_TESTS_H)
--
2.20.1.611.gfbb209baf1-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: remove generated verifier/tests.h on 'make clean'
2019-02-01 23:46 [PATCH bpf-next] selftests/bpf: remove generated verifier/tests.h on 'make clean' Stanislav Fomichev
@ 2019-02-01 23:47 ` Jakub Kicinski
2019-02-01 23:53 ` Alexei Starovoitov
2019-02-02 6:16 ` Y Song
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2019-02-01 23:47 UTC (permalink / raw)
To: Stanislav Fomichev; +Cc: netdev, davem, ast, daniel, quentin.monnet
On Fri, 1 Feb 2019 15:46:38 -0800, Stanislav Fomichev wrote:
> 'make clean' is supposed to remove generated files.
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Ah, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: remove generated verifier/tests.h on 'make clean'
2019-02-01 23:47 ` Jakub Kicinski
@ 2019-02-01 23:53 ` Alexei Starovoitov
0 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2019-02-01 23:53 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Stanislav Fomichev, netdev, davem, ast, daniel, quentin.monnet
On Fri, Feb 01, 2019 at 03:47:38PM -0800, Jakub Kicinski wrote:
> On Fri, 1 Feb 2019 15:46:38 -0800, Stanislav Fomichev wrote:
> > 'make clean' is supposed to remove generated files.
> >
> > Signed-off-by: Stanislav Fomichev <sdf@google.com>
>
> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied, Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: remove generated verifier/tests.h on 'make clean'
2019-02-01 23:46 [PATCH bpf-next] selftests/bpf: remove generated verifier/tests.h on 'make clean' Stanislav Fomichev
2019-02-01 23:47 ` Jakub Kicinski
@ 2019-02-02 6:16 ` Y Song
1 sibling, 0 replies; 4+ messages in thread
From: Y Song @ 2019-02-02 6:16 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: netdev, David Miller, Alexei Starovoitov, Daniel Borkmann,
Jakub Kicinski, Quentin Monnet
On Fri, Feb 1, 2019 at 3:49 PM Stanislav Fomichev <sdf@google.com> wrote:
>
> 'make clean' is supposed to remove generated files.
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Yonghong Song <yhs@fb.com>
> ---
> tools/testing/selftests/bpf/Makefile | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-02 6:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-01 23:46 [PATCH bpf-next] selftests/bpf: remove generated verifier/tests.h on 'make clean' Stanislav Fomichev
2019-02-01 23:47 ` Jakub Kicinski
2019-02-01 23:53 ` Alexei Starovoitov
2019-02-02 6:16 ` Y Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).