From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F86C282D8 for ; Sat, 2 Feb 2019 02:41:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD1372086C for ; Sat, 2 Feb 2019 02:41:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RdJZxxjj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726574AbfBBCiQ (ORCPT ); Fri, 1 Feb 2019 21:38:16 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:33973 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbfBBCiQ (ORCPT ); Fri, 1 Feb 2019 21:38:16 -0500 Received: by mail-pl1-f193.google.com with SMTP id w4so4160274plz.1 for ; Fri, 01 Feb 2019 18:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sO+x6coaonm8ok/iLcNwVk0p4Eop2RabAQ4d0n1U18o=; b=RdJZxxjjYIKClMLtEL3PXq5aOrRfBi/AE9xw4HDoW2gP1k9U324gPM6Wi1Eo1y4dBh XZCZGojoew6QNTimNbePCyqy7J6n/YFVueteAbJxeirKkhdm6MJzgvvJPHHVzxiToLa4 YpTKd9f0kptsc5JCaVOutufjLiRV5+waDYP3XdhuUzjzh9XBOi+7c6pj3/wnerg1ZKCX FYxmA+lch/9A0PexTBJX4jgqmTuW/aTZRTu0OhWfGV1M0a+xyFbcDOWTJgthYw37gK4i 8fwqDFi3g8qJqd0geB2gW6IHluUanufwcoGDdffA6cbsAh0WS4cGpR4GxDk9t5/DjTLc oZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sO+x6coaonm8ok/iLcNwVk0p4Eop2RabAQ4d0n1U18o=; b=Gkdl1tQtmP198P7tq+Fkmk7WjI3AK7tmY5CV/IwblKmFkchfEjSqz5NjRel8V7ZIuK /BxaSGoWTrNzgtAcz/k+GOZLl6uuOYe7L7OZA649dEY+ly6rRdhJFkzbzkt9PCKKZISM /rOQmYMTs+3uXVarMypdVWjkx2w2N3XSw5rv7nD59osWq2Spze6iO9pZxwDBZq+t4kVR DVohngFZnvTlKGCv//bTNSb28qCKA0NjawHy+cgdoCfCDyaGMbyDllO5zrEeXqCMt20q AEQ8GpWfOVD6N3WXQlK7nBYieNIawUwX27u/6dMvGqkCVKNYvNYlplILu8j3sYCljHEz ASZQ== X-Gm-Message-State: AJcUukd26vE3BlW/PnVWLMRetEie0BKHK17GZUS3OE9QpOWPpRe000sE bf+rn74RI3HiK8bur6cGnaPj6Zmx X-Google-Smtp-Source: ALg8bN6RAkbO3SOBj1Mi0o63Y/mEBOEJ3phfIvzXVdPeDqPYweTui6B7T+yrbQML6w09yqtMF6kROw== X-Received: by 2002:a17:902:a50a:: with SMTP id s10mr40211598plq.278.1549075095813; Fri, 01 Feb 2019 18:38:15 -0800 (PST) Received: from localhost (c-71-198-144-65.hsd1.ca.comcast.net. [71.198.144.65]) by smtp.gmail.com with ESMTPSA id b9sm11858191pfi.118.2019.02.01.18.38.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Feb 2019 18:38:15 -0800 (PST) Date: Fri, 1 Feb 2019 18:38:13 -0800 From: Richard Cochran To: Sebastian Andrzej Siewior Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org Subject: Re: [PATCH v2] net: dp83640: expire old TX-skb Message-ID: <20190202023813.sv53aeyfkvseog4w@localhost> References: <20190201210918.gvufqxpqzvuzfk5n@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190201210918.gvufqxpqzvuzfk5n@linutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 01, 2019 at 10:09:18PM +0100, Sebastian Andrzej Siewior wrote: > During sendmsg() a cloned skb is saved via dp83640_txtstamp() in > ->tx_queue. After the NIC sends this packet, the PHY will reply with a > timestamp for that TX packet. If the cable is pulled at the right time I > don't see that packet. It might gets flushed as part of queue shutdown > on NIC's side. > Once the link is up again then after the next sendmsg() we enqueue > another skb in dp83640_txtstamp() and have two on the list. Then the PHY > will send a reply and decode_txts() attaches it to the first skb on the > list. > No crash occurs since refcounting works but we are one packet behind. > linuxptp/ptp4l usually closes the socket and opens a new one (in such a > timeout case) so those "stale" replies never get there. However it does > not resume normal operation anymore. > > Purge old skbs in decode_txts(). > > Cc: stable@vger.kernel.org > Signed-off-by: Sebastian Andrzej Siewior > Reviewed-by: Kurt Kanzenbach Acked-by: Richard Cochran