From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13250C282D7 for ; Sat, 2 Feb 2019 22:00:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B54C920855 for ; Sat, 2 Feb 2019 22:00:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="PcYSfMUD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbfBBWAw (ORCPT ); Sat, 2 Feb 2019 17:00:52 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:34930 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726569AbfBBWAw (ORCPT ); Sat, 2 Feb 2019 17:00:52 -0500 Received: by mail-oi1-f195.google.com with SMTP id v6so8761476oif.2 for ; Sat, 02 Feb 2019 14:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=317gpg6L6bT/BINFGNHhl4OV+79X0dvQA++Fwf0LDv0=; b=PcYSfMUDmnbkz/8+c5hWrtiEEKWcJUcDYhruHtlxbQT8PGJ/VS5ThHnQ0DCVZySUwl 77xJckUYDrZsXDEhjAtHRqpj8L6NUnq07xVYuKZFnEeEp+x/QRZe970RizLimwIJTAMG 7Ul1Vsut0au8wmLn32ZJPCzzVJWi+8fGJIUCjqk1Wdqilvr///o2lZuSJutA6aJnacjr 6u4Xr489/MDyK2iRfF9MotGf8oMVA3PRenRrzTO+qcu8tZHkiXN2WYbV67eBQzOTkiRL hgjYxd3MMhxYkBqaj2Cz5vmj/YitLpidI7u5ftBbI3vom/OAE/w3fKkbVkYQ/+X0kUm0 DXNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=317gpg6L6bT/BINFGNHhl4OV+79X0dvQA++Fwf0LDv0=; b=f6fk/aSaL6pcR7BGwIriQO99KUF4fSSEEBL8qZBW8jdE+5jRMhxM4glqVjW5fnHGL0 LV/bQYkh2AhWJeTJ05Boek8MBB6pS74fWBZfOnkKcDKWu4sPhurDSXpeK/NrxP82g9cJ A6P0Nb8Thc8APj41Rtexe7DgTJqFnjgp6smhVbS6a68oTpyqs+JEA9d4+Uy65LE4UawJ PhaCugHOf7MOKmtk1tOUOdmWNCLUZNRztRKzdTZl6sgC1K85a9AXP4rRXNooa4S0Fnn6 UMvTR8gXnnzZGjztYY080wBa5VD0gLKO5mjTZkuVYCgDi9YwvSBcqWtYFCjOofw4fZtj jZHQ== X-Gm-Message-State: AJcUuke2PA4qBl4FR61QiT3eN8YcA3MeB+7TNU/mGm9b/VpiirDFKFXV A+Kk7Y9JyVv9dXco7WsUdEJ8Hg== X-Google-Smtp-Source: AHgI3Ib5RFQCF5xdCbUdxkjHNWxu6GdCilHxoihWeBSi19bgFF94+eLw8LBbM6/O2jzvEU0RmLtYSw== X-Received: by 2002:a05:6808:97:: with SMTP id s23mr21317065oic.251.1549144851681; Sat, 02 Feb 2019 14:00:51 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([2600:1702:3ad0:a560::27]) by smtp.gmail.com with ESMTPSA id u19sm5197676oia.31.2019.02.02.14.00.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Feb 2019 14:00:51 -0800 (PST) Date: Sat, 2 Feb 2019 14:00:44 -0800 From: Jakub Kicinski To: Ido Schimmel Cc: "davem@davemloft.net" , "jiri@resnulli.us" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next] net: devlink: report cell size of shared buffers Message-ID: <20190202140044.4185ef16@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190202123549.GA24795@splinter> References: <20190202015628.30877-1-jakub.kicinski@netronome.com> <20190202123549.GA24795@splinter> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 2 Feb 2019 12:35:51 +0000, Ido Schimmel wrote: > On Fri, Feb 01, 2019 at 05:56:28PM -0800, Jakub Kicinski wrote: > > Shared buffer allocation is usually done in cell increments. > > Drivers will either round up the allocation or refuse the > > configuration if it's not an exact multiple of cell size. > > Drivers know exactly the cell size of shared buffer, so help > > out users by providing this information in dumps. > > > > Signed-off-by: Jakub Kicinski > > Reviewed-by: Dirk van der Merwe > > Reviewed-by: Ido Schimmel > > I assume you're going to patch iproute2. Consider explaining what is > cell size in devlink-sb manpage. Will do, thanks!