From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F7A3C169C4 for ; Sun, 3 Feb 2019 17:37:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BDB020815 for ; Sun, 3 Feb 2019 17:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727154AbfBCRh3 (ORCPT ); Sun, 3 Feb 2019 12:37:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726784AbfBCRh3 (ORCPT ); Sun, 3 Feb 2019 12:37:29 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 748CF36883; Sun, 3 Feb 2019 17:37:29 +0000 (UTC) Received: from localhost (ovpn-112-14.rdu2.redhat.com [10.10.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 078186091C; Sun, 3 Feb 2019 17:37:27 +0000 (UTC) Date: Sun, 03 Feb 2019 09:37:26 -0800 (PST) Message-Id: <20190203.093726.615554483861134836.davem@redhat.com> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: realtek: add generic Realtek PHY driver From: David Miller In-Reply-To: <74416e89-bcd5-6c3d-b38a-2ed9ad6a0c0b@gmail.com> References: <74416e89-bcd5-6c3d-b38a-2ed9ad6a0c0b@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sun, 03 Feb 2019 17:37:29 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Sun, 3 Feb 2019 16:07:33 +0100 > The integrated PHY's of later RTL8168 network chips report the generic > PHYID 0x001cc800 (Realtek OUI, model and revision number both set to > zero) and therefore currently the genphy driver is used. > > To be able to use the paged version of e.g. phy_write() we need a > PHY driver with the read_page and write_page callbacks implemented. > So basically make a copy of the genphy driver, just with the > read_page and write_page callbacks being set. > > Signed-off-by: Heiner Kallweit Applied, thanks.