* [PATCH net-next] ipv4/igmp: Don't drop IGMP pkt with zeros src addr
@ 2019-01-31 23:00 Edward Chron
2019-02-03 17:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Edward Chron @ 2019-01-31 23:00 UTC (permalink / raw)
To: davem; +Cc: netdev, colona, echron
Don't drop IGMP packets with a source address of all zeros which are
IGMP proxy reports. This is documented in Section 2.1.1 IGMP
Forwarding Rules of RFC 4541 IGMP and MLD Snooping Switches
Considerations.
Signed-off-by: Edward Chron <echron@arista.com>
---
net/ipv4/route.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 99be68b15da0..16259ea9df54 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1608,7 +1608,8 @@ int ip_mc_validate_source(struct sk_buff *skb, __be32 daddr, __be32 saddr,
return -EINVAL;
if (ipv4_is_zeronet(saddr)) {
- if (!ipv4_is_local_multicast(daddr))
+ if (!ipv4_is_local_multicast(daddr) &&
+ ip_hdr(skb)->protocol != IPPROTO_IGMP)
return -EINVAL;
} else {
err = fib_validate_source(skb, saddr, 0, tos, 0, dev,
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv4/igmp: Don't drop IGMP pkt with zeros src addr
2019-01-31 23:00 [PATCH net-next] ipv4/igmp: Don't drop IGMP pkt with zeros src addr Edward Chron
@ 2019-02-03 17:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-02-03 17:54 UTC (permalink / raw)
To: echron; +Cc: netdev, colona
From: Edward Chron <echron@arista.com>
Date: Thu, 31 Jan 2019 15:00:40 -0800
> Don't drop IGMP packets with a source address of all zeros which are
> IGMP proxy reports. This is documented in Section 2.1.1 IGMP
> Forwarding Rules of RFC 4541 IGMP and MLD Snooping Switches
> Considerations.
>
> Signed-off-by: Edward Chron <echron@arista.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-03 17:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-31 23:00 [PATCH net-next] ipv4/igmp: Don't drop IGMP pkt with zeros src addr Edward Chron
2019-02-03 17:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).