From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31CE5C169C4 for ; Sun, 3 Feb 2019 20:11:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F31B92148E for ; Sun, 3 Feb 2019 20:11:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbfBCULr (ORCPT ); Sun, 3 Feb 2019 15:11:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:43434 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726599AbfBCULr (ORCPT ); Sun, 3 Feb 2019 15:11:47 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E188814C2C92E; Sun, 3 Feb 2019 12:11:46 -0800 (PST) Date: Sun, 03 Feb 2019 12:11:44 -0800 (PST) Message-Id: <20190203.121144.623666032377925349.davem@davemloft.net> To: yangbo.lu@nxp.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, richardcochran@gmail.com, robh+dt@kernel.org, claudiu.manoil@nxp.com Subject: Re: [v2, 0/9] Add ENETC PTP clock driver From: David Miller In-Reply-To: <20190203.113921.1847323007238920901.davem@davemloft.net> References: <20190202025707.10794-1-yangbo.lu@nxp.com> <20190203.113921.1847323007238920901.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 03 Feb 2019 12:11:47 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Miller Date: Sun, 03 Feb 2019 11:39:21 -0800 (PST) > From: Yangbo Lu > Date: Sat, 2 Feb 2019 10:56:58 +0800 > >> There is same QorIQ 1588 timer IP block on the new ENETC Ethernet >> controller with eTSEC/DPAA Ethernet controllers. However it's >> different endianness (little-endian) and using PCI driver. >> >> To support ENETC PTP driver, ptp_qoriq driver needed to be >> reworked to make functions global for reusing, to add little- >> endian support, to add ENETC memory map support, and to add >> ENETC dependency for ptp_qoriq driver. >> >> In addition, although ENETC PTP driver is a PCI driver, the dts >> node still could be used. Currently the ls1028a dtsi which is >> the only platform by now using ENETC is not complete, so there >> is still dependency for ENETC PTP node upstreaming. This will >> be done in the near future. The hardware timestamping support >> for ENETC is done but needs to be reworked with new method in >> internal git tree, and will be sent out soon. > > Series applied. Once AGAIN, I had to revert: [davem@localhost net-next]$ make -s -j8 ERROR: "ptp_qoriq_remove_debugfs" [drivers/net/ethernet/freescale/enetc/fsl-enetc-ptp.ko] undefined! make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 make: *** [Makefile:1262: modules] Error 2 Please do an allmodconfig build and don't resubmit this until it all passes. Thank you.