From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F6EC282C4 for ; Mon, 4 Feb 2019 17:21:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B85512175B for ; Mon, 4 Feb 2019 17:21:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729134AbfBDRV0 (ORCPT ); Mon, 4 Feb 2019 12:21:26 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53974 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726542AbfBDRV0 (ORCPT ); Mon, 4 Feb 2019 12:21:26 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 94D04108C036A; Mon, 4 Feb 2019 09:21:25 -0800 (PST) Date: Mon, 04 Feb 2019 09:21:24 -0800 (PST) Message-Id: <20190204.092124.2218605529866288555.davem@davemloft.net> To: petrm@mellanox.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, idosch@mellanox.com, paulb@mellanox.com Subject: Re: [PATCH net] net: cls_flower: Remove filter from mask before freeing it From: David Miller In-Reply-To: <6f8e5a3f3ad2d6bc2f5a81ce1be1167b8aa456df.1549291065.git.petrm@mellanox.com> References: <6f8e5a3f3ad2d6bc2f5a81ce1be1167b8aa456df.1549291065.git.petrm@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Feb 2019 09:21:25 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Petr Machata Date: Mon, 4 Feb 2019 14:50:38 +0000 > In fl_change(), when adding a new rule (i.e. fold == NULL), a driver may > reject the new rule, for example due to resource exhaustion. By that > point, the new rule was already assigned a mask, and it was added to > that mask's hash table. The clean-up path that's invoked as a result of > the rejection however neglects to undo the hash table addition, and > proceeds to free the new rule, thus leaving a dangling pointer in the > hash table. > > Fix by removing fnew from the mask's hash table before it is freed. > > Fixes: 35cc3cefc4de ("net/sched: cls_flower: Reject duplicated rules > also under skip_sw") Please do not break up lone Fixes: tag lines in the future, I fixed it up for you this time. > Signed-off-by: Petr Machata > Acked-by: Jiri Pirko > Reviewed-by: Ido Schimmel Applied and queued up for -stable.