netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: linus.walleij@linaro.org
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
	Laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v2] net: phy: fixed-phy: Drop GPIO from fixed_phy_add()
Date: Mon, 04 Feb 2019 18:33:57 -0800 (PST)	[thread overview]
Message-ID: <20190204.183357.1990895896344657948.davem@davemloft.net> (raw)
In-Reply-To: <20190204102618.20583-1-linus.walleij@linaro.org>

From: Linus Walleij <linus.walleij@linaro.org>
Date: Mon,  4 Feb 2019 11:26:18 +0100

> All users of the fixed_phy_add() pass -1 as GPIO number
> to the fixed phy driver, and all users of fixed_phy_register()
> pass -1 as GPIO number as well, except for the device
> tree MDIO bus.
> 
> Any new users should create a proper device and pass the
> GPIO as a descriptor associated with the device so delete
> the GPIO argument from the calls and drop the code looking
> requesting a GPIO in fixed_phy_add().
> 
> In fixed phy_register(), investigate the "fixed-link"
> node and pick the GPIO descriptor from "link-gpios" if
> this property exists. Move the corresponding code out
> of of_mdio.c as the fixed phy code anyways requires
> OF to be in use.
> 
> Tested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

This looks like net-next material, so that's where I have applied
this.

Thanks.

      reply	other threads:[~2019-02-05 18:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 10:26 [PATCH v2] net: phy: fixed-phy: Drop GPIO from fixed_phy_add() Linus Walleij
2019-02-05  2:33 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204.183357.1990895896344657948.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).