From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Cfxk=QM=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.2 required=3.0 tests=DATE_IN_PAST_12_24,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 62E36C282D7
	for <netdev@archiver.kernel.org>; Tue,  5 Feb 2019 18:25:07 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 3946A2175B
	for <netdev@archiver.kernel.org>; Tue,  5 Feb 2019 18:25:07 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730089AbfBESZG (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 5 Feb 2019 13:25:06 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:45972 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729983AbfBESZD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Feb 2019 13:25:03 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 31FB2133FABD6;
        Tue,  5 Feb 2019 10:25:01 -0800 (PST)
Date:   Mon, 04 Feb 2019 18:33:57 -0800 (PST)
Message-Id: <20190204.183357.1990895896344657948.davem@davemloft.net>
To:     linus.walleij@linaro.org
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
        Laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v2] net: phy: fixed-phy: Drop GPIO from fixed_phy_add()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190204102618.20583-1-linus.walleij@linaro.org>
References: <20190204102618.20583-1-linus.walleij@linaro.org>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Feb 2019 10:25:01 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Linus Walleij <linus.walleij@linaro.org>
Date: Mon,  4 Feb 2019 11:26:18 +0100

> All users of the fixed_phy_add() pass -1 as GPIO number
> to the fixed phy driver, and all users of fixed_phy_register()
> pass -1 as GPIO number as well, except for the device
> tree MDIO bus.
> 
> Any new users should create a proper device and pass the
> GPIO as a descriptor associated with the device so delete
> the GPIO argument from the calls and drop the code looking
> requesting a GPIO in fixed_phy_add().
> 
> In fixed phy_register(), investigate the "fixed-link"
> node and pick the GPIO descriptor from "link-gpios" if
> this property exists. Move the corresponding code out
> of of_mdio.c as the fixed phy code anyways requires
> OF to be in use.
> 
> Tested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

This looks like net-next material, so that's where I have applied
this.

Thanks.