From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Cfxk=QM=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.2 required=3.0 tests=DATE_IN_PAST_12_24,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0C67BC282CC
	for <netdev@archiver.kernel.org>; Tue,  5 Feb 2019 18:25:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E3F902175B
	for <netdev@archiver.kernel.org>; Tue,  5 Feb 2019 18:25:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730020AbfBESZE (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 5 Feb 2019 13:25:04 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:45970 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729941AbfBESZD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Feb 2019 13:25:03 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id F38CA133FABDA;
        Tue,  5 Feb 2019 10:25:01 -0800 (PST)
Date:   Mon, 04 Feb 2019 19:19:17 -0800 (PST)
Message-Id: <20190204.191917.526156939380773170.davem@davemloft.net>
To:     edumazet@google.com
Cc:     netdev@vger.kernel.org, eric.dumazet@gmail.com,
        dhowells@redhat.com, syzkaller@googlegroups.com
Subject: Re: [PATCH net] rxrpc: bad unlock balance in rxrpc_recvmsg
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190204163606.236419-1-edumazet@google.com>
References: <20190204163606.236419-1-edumazet@google.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Feb 2019 10:25:02 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Eric Dumazet <edumazet@google.com>
Date: Mon,  4 Feb 2019 08:36:06 -0800

> When either "goto wait_interrupted;" or "goto wait_error;"
> paths are taken, socket lock has already been released.
> 
> This patch fixes following syzbot splat :
 ...
> Fixes: 248f219cb8bc ("rxrpc: Rewrite the data and ack handling code")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: David Howells <dhowells@redhat.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>

David H., please take a look at this.

I can apply it directly and queue it up for -stable, just let me
know.

Thanks.