From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A81DC282DB for ; Mon, 4 Feb 2019 01:45:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C23D217D6 for ; Mon, 4 Feb 2019 01:45:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="K6jH+SiK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727678AbfBDBjt (ORCPT ); Sun, 3 Feb 2019 20:39:49 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:39504 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727507AbfBDBjs (ORCPT ); Sun, 3 Feb 2019 20:39:48 -0500 Received: by mail-qk1-f193.google.com with SMTP id c21so7443375qkl.6 for ; Sun, 03 Feb 2019 17:39:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bJUxIlYFmxu1Rc7bJM8knfN61rKcYeVyWG11TsqJLno=; b=K6jH+SiKjO+3s4TIpe0tS3e52sqoOjXkIxcQfScgWGpbDKtueUVOH/Z9uyIo1zYRje Dqvu1r4ZSFGRwM7r2NHgdG5ZrKFQ199NKjx3+WTepAZPmpiZzJ+NX1uH856YO48B+nTu aAYidR/Tf0c6pxdIGUP/P4rmHx7ltvRltRJHSjrTU81FRQKBOaEEzxgMNEXDNZ1uF3VM LtNnAHqNjbSgaQxWeGIBdLhUF23cFJ3wf6ST+dIRle8O9wPMB501+ul2Lk/aUFpScpz1 XLBTi9bFWAhso9OvGtg31kaJPKhgdLvxSQtjJO8Z4NyhhargZLgQYojbyKpOBoB/t9Wk Mjdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bJUxIlYFmxu1Rc7bJM8knfN61rKcYeVyWG11TsqJLno=; b=jDabKcPGjuI/6dQ6adZ9LVfjR99EmMzsiIfa5HY2JR+09/akq1aeIodB3wolEWVunR NYvPqMWPZZqPimxUHmgm8IKF2VMywUgMT+jR/YJ29pcIga9iU5zQ16TpPnXhnd+r5yNz sSSRk6+KEDceXA1lhxQuMTCOwR6l+GOLD/TBhIWnQAJAyAukoaBnoxII7JyZvQFZiVWd wPx6QgezgFvuSmWBV8oNRaEpw7tPygJ5Hu/lO8GZ7IOLPol0Nqq9fWzGKgZ6b+m/EsGd sKQCLbx0C6OR6OAxmW8H3YaCH4VKBObYvMoCfCoZFwHa0C+lhddXkvR2w5jmg0XtI5u1 uOKw== X-Gm-Message-State: AJcUukej4cAhQuy/CzZ7bVAhd9AcN/zggOK+WO1iXgq3HPJ0tjcH0psq WCLe3/lZ9lDojY9ZfTo0JOX75A== X-Google-Smtp-Source: ALg8bN4lP0GTEF4LosYT3tgkAskWfYUauX1M3eY1H0ptr62nNLyo8KeChceqwjfhlQ7U+mgCWHkgmg== X-Received: by 2002:a37:27d2:: with SMTP id n201mr43992947qkn.63.1549244387612; Sun, 03 Feb 2019 17:39:47 -0800 (PST) Received: from jkicinski-Precision-T1700.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id o25sm13555770qtj.10.2019.02.03.17.39.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Feb 2019 17:39:46 -0800 (PST) From: Jakub Kicinski To: idosch@mellanox.com, jiri@resnulli.us, dsahern@gmail.com Cc: stephen@networkplumber.org, oss-drivers@netronome.com, netdev@vger.kernel.org, Jakub Kicinski Subject: [PATCH iproute2-next] devlink: report cell size Date: Sun, 3 Feb 2019 17:39:19 -0800 Message-Id: <20190204013919.816-1-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Print the value of DEVLINK_ATTR_SB_POOL_CELL_SIZE, if reported. Example: pci/0000:82:00.0: sb 1 pool 0 type egress size 40945664 thtype static cell_size 2048 sb 2 pool 0 type egress size 258867200 thtype static cell_size 10240 ... Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- devlink/devlink.c | 3 +++ man/man8/devlink-sb.8 | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/devlink/devlink.c b/devlink/devlink.c index fc4b18d1b613..40f6105af109 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -2891,6 +2891,9 @@ static void pr_out_sb_pool(struct dl *dl, struct nlattr **tb) mnl_attr_get_u32(tb[DEVLINK_ATTR_SB_POOL_SIZE])); pr_out_str(dl, "thtype", threshold_type_name(mnl_attr_get_u8(tb[DEVLINK_ATTR_SB_POOL_THRESHOLD_TYPE]))); + if (tb[DEVLINK_ATTR_SB_POOL_CELL_SIZE]) + pr_out_uint(dl, "cell_size", + mnl_attr_get_u32(tb[DEVLINK_ATTR_SB_POOL_CELL_SIZE])); pr_out_handle_end(dl); } diff --git a/man/man8/devlink-sb.8 b/man/man8/devlink-sb.8 index 1882833a3fa7..767c932dd4c1 100644 --- a/man/man8/devlink-sb.8 +++ b/man/man8/devlink-sb.8 @@ -128,6 +128,16 @@ Behaviour of this argument it the same for every command. - specifies the devlink device to show pools. If this argument is omitted all pools of all devices are listed. +Display available pools listing their +.B type, size, thtype +and +.B cell_size. cell_size +is the allocation granularity of memory within the shared buffer. Drivers +may round up, round down or reject +.B size +passed to the set command if its not multiple of +.B cell_size. + .SS devlink sb pool set - set attributes of pool .PP -- 2.19.2