From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06710C282C4 for ; Mon, 4 Feb 2019 07:20:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C06A7217D9 for ; Mon, 4 Feb 2019 07:20:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="X4PZvOER" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbfBDHUG (ORCPT ); Mon, 4 Feb 2019 02:20:06 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52337 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbfBDHUG (ORCPT ); Mon, 4 Feb 2019 02:20:06 -0500 Received: by mail-wm1-f66.google.com with SMTP id m1so11963795wml.2 for ; Sun, 03 Feb 2019 23:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5MHYij4Bjtpl3CKuZHq/6Ydh2929/p7IUkltGrD5dPs=; b=X4PZvOER4r32ChmYPK50isKJxdE7Q+VQArO/QApkYTge5sHQ833MsyR2qPfX6yC+U9 f+aXtpnbOqPS0jeSE06Zg1vRJ870jrQYeoAcvfHwPeItL7APgcxy3BK3iADTzLmnKqZx 0g9myhznyEAQCoSwjcEGNU8vVCRaabDeJELmFARz5ND8yIPcav38+iSImhuVv8j5GrP3 yzhQFdtDqUwkUq2nDqD1f1NSnbE0PdqF3rZqeSfcv7djqHKj+ENKhEwtNIRdHDrUKqqu OQVrO1M8hjIZsIvQDlJuQh4v4OdVdXABQwSRx9HFjv/wflWo0XcDF8gBKn6UN1wsqMxR NtKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5MHYij4Bjtpl3CKuZHq/6Ydh2929/p7IUkltGrD5dPs=; b=bhcq36QFHFiQrFOJ3dFx0f7d1DXFh0UEApLFs1YQ26+z8ww3wTqpYX/zxZC4yV+1C5 H5z0qZSzho9I1fhyyuVi2nfT5UkUDq6ONzG/7zYOFRlZo66zBBNwX38OjWpEZNtQHGBw v1jQmiONJ9FFJ65dBh4NRNPYgWa5CKtpBm4Ick4NXvfH4vxo0NT8jEVNrrQyHgeUPixy GPLZFcSo86XY0mplbl/Np9q/apk++1PuGLH0PiXCYR4Wzx+rGyi3/2iMfliPKO4CH88D WUH2Z5u4W+zyQmsdiWmcepMk3HxaLECzIoQ/Rjb6cSl0mBD15jyPmTJ4H5FTe0xaN10W djrg== X-Gm-Message-State: AHQUAuZLD67wupYD1qsWRJT4FyzAYWIH1MHfTM2bCq1hCQ3kPfaIKSXU bxXqIqr6Vje+AgsMfXpACUH8Tg== X-Google-Smtp-Source: AHgI3IZmfXMQs08rHvn4BU7WSu7BK4tox55mavoCjnwpbSvZwcfbiBnXlOwhE4dCKN/FbJNGhSLk2g== X-Received: by 2002:a1c:6508:: with SMTP id z8mr12224348wmb.28.1549264804567; Sun, 03 Feb 2019 23:20:04 -0800 (PST) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id z12sm11016014wrh.35.2019.02.03.23.20.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Feb 2019 23:20:04 -0800 (PST) Date: Mon, 4 Feb 2019 08:10:59 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH iproute2-next v2] devlink: add info subcommand Message-ID: <20190204071059.GC2249@nanopsycho> References: <20190204005456.22912-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204005456.22912-1-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 01:54:56AM CET, jakub.kicinski@netronome.com wrote: >Add support for reading the device serial number, driver name >and various versions. Example: > >$ devlink dev info pci/0000:05:00.0 >pci/0000:05:00.0: > driver nfp > serial_number 16240145 > versions: > fixed: > board.id AMDA0099-0001 > board.rev 07 > board.vendor SMA > board.model carbon > running: > fw.mgmt: 010156.010156.010156 Sometimes you have "x: y" and sometimes you have "x y". Please be consistent. Please also include json output here. Thanks! > fw.cpld: 0x44 > fw.app: sriov-2.1.16 > stored: > fw.mgmt: 010158.010158.010158 > fw.cpld: 0x44 > fw.app: sriov-2.1.20 > >v2 (Jiri): > - remove filtering; > - add example in the commit message. >RFCv2: > - make info subcommand of dev. > [...]