From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F90C282C4 for ; Mon, 4 Feb 2019 14:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A85072082F for ; Mon, 4 Feb 2019 14:44:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="G3Z3llDQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729104AbfBDOox (ORCPT ); Mon, 4 Feb 2019 09:44:53 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:38950 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728767AbfBDOow (ORCPT ); Mon, 4 Feb 2019 09:44:52 -0500 Received: by mail-qt1-f193.google.com with SMTP id u47so92450qtj.6 for ; Mon, 04 Feb 2019 06:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qk4q7rNNGSl2obyb/AOrS2u/9E6w0W47dTZaYboq3hs=; b=G3Z3llDQR5H6c52k5Stbh8QzM3KFGP7rCgfya4s+ZVK0l9TpyYllTq+cfswNCsX/CL e5ZYcLQeL3MgwHm5QfSgYJFkh0yK6jzWaEMFCLQ7xiMqALI55FyWeyYdoKl7D7uKiRmw BfbPXuTdLLLnizidpm9cR0v8KKVkrifKo3yl9Mm4A7/qTZrDLI+o/I00hyA/9TL8KpLw a9rmnAl3SoLnfiuJ3usatcDVThSHQJlKOt18Uh0N1QwE6L50XkkWW9uewFJCD/dNw+f8 tt2vWZj1Xb5cdCa9k7iYBkog5KreB54XPe/y6yMAqNKku6tKRKnlpsrzwJyESUlVyPFu wTag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qk4q7rNNGSl2obyb/AOrS2u/9E6w0W47dTZaYboq3hs=; b=KYarAiP149B/2be7EeZM70H9VVmbZdfMFYOJy9BIhN7KxIws3btLGQ2aVH655dOrWM k0hp+eR8PdglLl+LP85BnEyh3wPF1kmfpPzN6t1R8pyVolcu/B89FJ7hVgTM7qVGvzi/ mMAyc0290jpbNK5GJ7m8PK7+ILFxqtyYZapxncFp4QVYmStM8kh9+lfkxy7zQReZ8gP1 WlV5bV4KguNgar9ny4eJSLT283YUD3QvQs/DUoknYz93wgTsi1VPFSWNsXsefQEBh1Vz pK9r1p/IXUr4YglA+nd9Y3WXJMIo6JFYS7fvysqfbDpaKp+cqVaUj5/olKFGULqOtGMq Urww== X-Gm-Message-State: AJcUukenDcakxmNRn7MG1bemNqaAiHBHMm58/a3q0N3AZk/s/QwjjYIR xcJ2Uxe89JiwAFf7l5oMV7Pphw== X-Google-Smtp-Source: ALg8bN7AZnOhkhwZka+cV/Pe8tXv3N/BOB3hKYtwDrJcONMgO9Vp8N1e+2E2YlAmYg62fM/N6XHtvg== X-Received: by 2002:ac8:2353:: with SMTP id b19mr49110173qtb.187.1549291491593; Mon, 04 Feb 2019 06:44:51 -0800 (PST) Received: from jkicinski-Precision-T1700.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id v16sm4605025qth.77.2019.02.04.06.44.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 06:44:50 -0800 (PST) From: Jakub Kicinski To: idosch@mellanox.com, jiri@resnulli.us, dsahern@gmail.com Cc: stephen@networkplumber.org, oss-drivers@netronome.com, netdev@vger.kernel.org, Jakub Kicinski Subject: [PATCH iproute2-next v2] devlink: report cell size Date: Mon, 4 Feb 2019 06:44:42 -0800 Message-Id: <20190204144442.5704-1-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Print the value of DEVLINK_ATTR_SB_POOL_CELL_SIZE, if reported. Example: pci/0000:82:00.0: sb 1 pool 0 type egress size 40945664 thtype static cell_size 2048 sb 2 pool 0 type egress size 258867200 thtype static cell_size 10240 ... v2: - fix spelling. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- devlink/devlink.c | 3 +++ man/man8/devlink-sb.8 | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/devlink/devlink.c b/devlink/devlink.c index fc4b18d1b613..40f6105af109 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -2891,6 +2891,9 @@ static void pr_out_sb_pool(struct dl *dl, struct nlattr **tb) mnl_attr_get_u32(tb[DEVLINK_ATTR_SB_POOL_SIZE])); pr_out_str(dl, "thtype", threshold_type_name(mnl_attr_get_u8(tb[DEVLINK_ATTR_SB_POOL_THRESHOLD_TYPE]))); + if (tb[DEVLINK_ATTR_SB_POOL_CELL_SIZE]) + pr_out_uint(dl, "cell_size", + mnl_attr_get_u32(tb[DEVLINK_ATTR_SB_POOL_CELL_SIZE])); pr_out_handle_end(dl); } diff --git a/man/man8/devlink-sb.8 b/man/man8/devlink-sb.8 index 1882833a3fa7..0deacd9ccd23 100644 --- a/man/man8/devlink-sb.8 +++ b/man/man8/devlink-sb.8 @@ -128,6 +128,16 @@ Behaviour of this argument it the same for every command. - specifies the devlink device to show pools. If this argument is omitted all pools of all devices are listed. +Display available pools listing their +.B type, size, thtype +and +.B cell_size. cell_size +is the allocation granularity of memory within the shared buffer. Drivers +may round up, round down or reject +.B size +passed to the set command if it is not multiple of +.B cell_size. + .SS devlink sb pool set - set attributes of pool .PP -- 2.19.2