From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C0ADC282C4 for ; Mon, 4 Feb 2019 14:59:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A6322087C for ; Mon, 4 Feb 2019 14:59:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="v3aih98D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729357AbfBDO67 (ORCPT ); Mon, 4 Feb 2019 09:58:59 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:55044 "EHLO mail-wm1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727217AbfBDO67 (ORCPT ); Mon, 4 Feb 2019 09:58:59 -0500 Received: by mail-wm1-f45.google.com with SMTP id a62so158163wmh.4 for ; Mon, 04 Feb 2019 06:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5qmMZbUZJoyL6HWGpHZCZsQrTjZvZRFmNoGer7oAytk=; b=v3aih98DROEUCtx2EpEXipQLw2YHNWz4QCyv98g/kC++EA3t15Uh0gGsYrhgbKjYDi bGxjW+3WrfQi3Qw5qCCFalAolbhm6/w1qzd8ACTHBvpGBjPYSUMa6kbGCXp60/GqXJMX siozS13Dmv/CKqlBdjX+eckm0PTbHvAzzvJLB3AnBJixagomXXZL05BOFUyq5AaYsUeA KhfMZz8F2ZxlSNu8dbChIExCcLJOzBNbNKJgr9hwPKajLlBX2TCc0GZj55+vIVtp4gJ8 H8r9oazvJM4NNJEJ9BW+gzAZIPGMNV1o8M8/KHomYdTLD8UR3Mq9WvPFdrQdRqC+CrFG A73g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5qmMZbUZJoyL6HWGpHZCZsQrTjZvZRFmNoGer7oAytk=; b=mxuQzguxOWjTO7D+L1/4AqAunAwjPQKhFtuqB5U8RLTi7brqkWPn7nw9KbAYIihrSy ZXQ1yXrsYSubpZD49mKUTSLdSFrRCvNMyfGdQqLHghu+esYaDnwn4/lAe6z9hSwjS9t/ s2CGHcYO8l6oUJku+ZhWPhL1pycvGgDqEthAfnxWHHWyEw3/qHcBzaX+2GazT6isK5pN deO3aCXNchwUUhAxynLSJjRqhy9AKPWIevNZpErHMUQ3Kv2FzRHGcPkBcRQW9sfpycVc g8XutpTBcK/5SJvtWoZzNjJAgYUOj80KE5jktpV5ouHGptcRohUrDm5Geb5mZIqeca9o vQiA== X-Gm-Message-State: AHQUAuYZmJi9xKog7SQQu72a70zTHOGXHU+iADZ8hpCLDngoADiMUTKY GETALNXzTu015JINFxg9csxr0A== X-Google-Smtp-Source: AHgI3IZyvOVABgFzmA3d0ZZ2NwWqo5FRV8XrRVFCeyD+kCI+kum2CuL/66bUYmEldaIrOgAqVXcV6g== X-Received: by 2002:a1c:ac42:: with SMTP id v63mr13399014wme.119.1549292337180; Mon, 04 Feb 2019 06:58:57 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id k3sm11333228wrm.7.2019.02.04.06.58.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 06:58:56 -0800 (PST) Date: Mon, 4 Feb 2019 15:49:48 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH iproute2-next v3] devlink: add info subcommand Message-ID: <20190204144948.GA2118@nanopsycho> References: <20190204144343.5639-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204144343.5639-1-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 03:43:43PM CET, jakub.kicinski@netronome.com wrote: >Add support for reading the device serial number, driver name >and various versions. Example: > >$ devlink dev info pci/0000:82:00.0 >pci/0000:82:00.0: > driver nfp > serial_number 16240145 > versions: > fixed: > board.id AMDA0081-0001 > board.rev 15 > board.vendor SMA > board.model hydrogen > running: > fw.bundle_id - Wait, what are these "-" ? That looks a bit scarry. > fw.mgmt 010181.010181.0101d4 > fw.cpld 0x1030000 > fw.app abm-d372b6 > fw.undi 0.0.0 > fw.ncsi - > chip.init AMDA-0081-0001 20160318164536 > stored: > fw.bundle_id - > fw.mgmt 010181.010181.0101d4 > fw.cpld 0xfeedbeef > fw.app - > fw.undi 0.0.0 > fw.ncsi - > chip.init AMDA-0081-0001 20160318164536 > >$ devlink -jp dev info pci/0000:82:00.0 >{ > "info": { > "pci/0000:82:00.0": { > > "driver": "nfp", > "serial_number": "16240145", > "versions": { > "fixed": { > "board.id": "AMDA0081-0001", > "board.rev": "15", > "board.vendor": "SMA", > "board.model": "hydrogen" > }, > "running": { > "fw.bundle_id": "-", > "fw.mgmt": "010181.010181.0101d4", > "fw.cpld": "0x1030000", > "fw.app": "abm-d372b6", > "fw.undi": "0.0.0", > "fw.ncsi": "-", > "chip.init": "AMDA-0081-0001 20160318164536" > }, > "stored": { > "fw.bundle_id": "-", > "fw.mgmt": "010181.010181.0101d4", > "fw.cpld": "0xfeedbeef", > "fw.app": "-", > "fw.undi": "0.0.0", > "fw.ncsi": "-", > "chip.init": "AMDA-0081-0001 20160318164536" > } > } > } > } >} > >v3: > - show up-to-date output in the commit message. >v2 (Jiri): > - remove filtering; > - add example in the commit message. >RFCv2: > - make info subcommand of dev. > >Signed-off-by: Jakub Kicinski [...]