From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Yonghong Song <yhs@fb.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Magnus Karlsson <magnus.karlsson@intel.com>,
netdev@vger.kernel.org, Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH bpf-next v4 0/3] tools/bpf: changes of libbpf debug interfaces
Date: Mon, 4 Feb 2019 12:51:34 -0200 [thread overview]
Message-ID: <20190204145134.GA4290@redhat.com> (raw)
In-Reply-To: <20190202165228.jrcghbvro4st4thd@ast-mbp>
Em Sat, Feb 02, 2019 at 08:52:30AM -0800, Alexei Starovoitov escreveu:
> On Fri, Feb 01, 2019 at 04:14:13PM -0800, Yonghong Song wrote:
> > These are patches responding to my comments for
> > Magnus's patch (https://patchwork.ozlabs.org/patch/1032848/).
> > The goal is to make pr_* macros available to other C files
> > than libbpf.c, and to simplify API function libbpf_set_print().
> >
> > Specifically, Patch #1 used global functions
> > to facilitate pr_* macros in the header files so they
> > are available in different C files.
> > Patch #2 removes the global function libbpf_print_level_available()
> > which is added in Patch 1.
> > Patch #3 simplified libbpf_set_print() which takes only one print
> > function with a debug level argument among others.
> >
> > Changelogs:
> > v3 -> v4:
> > . rename libbpf internal header util.h to libbpf_util.h
> > . rename libbpf internal function libbpf_debug_print() to libbpf_print()
> > v2 -> v3:
> > . bailed out earlier in libbpf_debug_print() if __libbpf_pr is NULL
> > . added missing LIBBPF_DEBUG level check in libbpf.c __base_pr().
> > v1 -> v2:
> > . Renamed global function libbpf_dprint() to libbpf_debug_print()
> > to be more expressive.
> > . Removed libbpf_dprint_level_available() as it is used only
> > once in btf.c and we can remove it by optimizing for common cases.
> >
> > Yonghong Song (3):
> > tools/bpf: move libbpf pr_* debug print functions to headers
> > tools/bpf: print out btf log at LIBBPF_WARN level
> > tools/bpf: simplify libbpf API function libbpf_set_print()
> >
> > tools/lib/bpf/btf.c | 110 +++++++++---------
> > tools/lib/bpf/btf.h | 7 +-
> > tools/lib/bpf/libbpf.c | 47 ++++----
> > tools/lib/bpf/libbpf.h | 20 ++--
> > tools/lib/bpf/libbpf_util.h | 30 +++++
> > tools/lib/bpf/test_libbpf.cpp | 4 +-
> > tools/perf/util/bpf-loader.c | 32 ++---
>
> Overall looks good to me.
> Arnaldo, could you ack the set, so we can take it into bpf-next?
LGTM
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
next prev parent reply other threads:[~2019-02-04 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 0:14 [PATCH bpf-next v4 0/3] tools/bpf: changes of libbpf debug interfaces Yonghong Song
2019-02-02 0:14 ` [PATCH bpf-next v4 1/3] tools/bpf: move libbpf pr_* debug print functions to headers Yonghong Song
2019-02-02 0:14 ` [PATCH bpf-next v4 2/3] tools/bpf: print out btf log at LIBBPF_WARN level Yonghong Song
2019-02-02 0:14 ` [PATCH bpf-next v4 3/3] tools/bpf: simplify libbpf API function libbpf_set_print() Yonghong Song
2019-02-02 16:52 ` [PATCH bpf-next v4 0/3] tools/bpf: changes of libbpf debug interfaces Alexei Starovoitov
2019-02-04 14:51 ` Arnaldo Carvalho de Melo [this message]
2019-02-04 17:44 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204145134.GA4290@redhat.com \
--to=acme@redhat.com \
--cc=acme@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).