From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 319B4C282C4 for ; Mon, 4 Feb 2019 15:34:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3DC720823 for ; Mon, 4 Feb 2019 15:34:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="ZOpYdvQ/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730993AbfBDPer (ORCPT ); Mon, 4 Feb 2019 10:34:47 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55233 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfBDPer (ORCPT ); Mon, 4 Feb 2019 10:34:47 -0500 Received: by mail-wm1-f68.google.com with SMTP id a62so301101wmh.4 for ; Mon, 04 Feb 2019 07:34:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VH3R8vSYAWJ4PiuMFa1R7IQi4ft+e0lIQmZXjjvHNMw=; b=ZOpYdvQ/TgN8M2tuhIhq8tr3l9Dxlq3HDc1auN3usPzq1U7GD9pv2e6kUpM+hxQD4w 3FJX7fKl3wK8GTJPAZtOAWNrkfHs/7zNa4vYUMfQG+Nkh4/AvxXCyofxpIKTEHh2U+8P HaDsGvezzxB1TMGMCXXKgHlmX2oRsWmtwrkoe4QkUFD9Z9zcKf+UEfLvlVOOm23kchh/ jWuuNoKQsVxmB0+AGGJblRUNVT2sgPhxNhmAmWotP+PrXNGUKGR2dIHVxDDfWvV4eoor RKonbALm/eMFHShSVvrKeo3OyJMh5Q4nn35KE5z6RnlrHZNYrxxcmwp5WKBVqJLTUKs/ /IXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VH3R8vSYAWJ4PiuMFa1R7IQi4ft+e0lIQmZXjjvHNMw=; b=b8CyC324CfMHeHUwNSweHZgw0qnYwoIX5c8vGZgVdVmfQiQOsOtCde2Ewzghutp2Cj RmagrwRTaLm8V62N57woAmj0ZWYgS9w5osdD5AqHxRNSCAv+/cA1CiApOwG2kMe1VrVs zUMP5H52mV6izwm9f3xCb4XllUJG4t/juy88QXg7zk45CuE4xFjjSRz4ie+Gddwa86Gw o1oGmgfqgpmp/GTj/j7fW2XbJddoIvAKxF/GGbguHSqeihPVMV6azJQIE2JZjcEWDphB 68dQjxoe8OR4D37MS+oj26D0mugl1tlN/4mU6nLZyDXvN2EakY+DsUDX8Bf3gsyPz3GN z8UQ== X-Gm-Message-State: AHQUAuYDlReYwETVLnJ6IkTu/kD8/PDzPMeJHlZpw1Qyr9xsMgWyLJcA Ed0Q36yHADVpAilKEB5zrw7CXg== X-Google-Smtp-Source: AHgI3IZdcAsrCt3xAfkWPu4CMz8ihwOpwxit51ZGQiR7mLIS7ljDSuiVXefk7Va3It9lX4uvifV8Mg== X-Received: by 2002:a7b:c191:: with SMTP id y17mr6760131wmi.60.1549294485349; Mon, 04 Feb 2019 07:34:45 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id n15sm8890248wrt.21.2019.02.04.07.34.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 07:34:45 -0800 (PST) Date: Mon, 4 Feb 2019 16:25:37 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH iproute2-next v4] devlink: add info subcommand Message-ID: <20190204152537.GF2118@nanopsycho> References: <20190204152820.6607-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204152820.6607-1-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 04:28:20PM CET, jakub.kicinski@netronome.com wrote: >Add support for reading the device serial number, driver name >and various versions. Example: > >$ devlink dev info pci/0000:82:00.0 >pci/0000:82:00.0: > driver nfp > serial_number 16240145 > versions: > fixed: > board.id AMDA0081-0001 > board.rev 15 > board.vendor SMA > board.model hydrogen > running: > fw.mgmt 010181.010181.0101d4 > fw.cpld 0x1030000 > fw.app abm-d372b6 > fw.undi 0.0.2 > chip.init AMDA-0081-0001 20160318164536 > stored: > fw.mgmt 010181.010181.0101d4 > fw.app abm-d372b6 > fw.undi 0.0.2 > chip.init AMDA-0081-0001 20160318164536 > >$ devlink -jp dev info pci/0000:82:00.0 >{ > "info": { > "pci/0000:82:00.0": { > I just noticed, this extra line should not be here. > "driver": "nfp", > "serial_number": "16240145", > "versions": { > "fixed": { > "board.id": "AMDA0081-0001", > "board.rev": "15", > "board.vendor": "SMA", > "board.model": "hydrogen" > }, > "running": { > "fw.mgmt": "010181.010181.0101d4", > "fw.cpld": "0x1030000", > "fw.app": "abm-d372b6", > "fw.undi": "0.0.2", > "chip.init": "AMDA-0081-0001 20160318164536" > }, > "stored": { > "fw.mgmt": "010181.010181.0101d4", > "fw.app": "abm-d372b6", > "fw.undi": "0.0.2", > "chip.init": "AMDA-0081-0001 20160318164536" > } > } > } > } >} [...]