From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ADC7C282C4 for ; Mon, 4 Feb 2019 16:25:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33A522083B for ; Mon, 4 Feb 2019 16:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="xYUbq1+n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727058AbfBDQZN (ORCPT ); Mon, 4 Feb 2019 11:25:13 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:37781 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726542AbfBDQZM (ORCPT ); Mon, 4 Feb 2019 11:25:12 -0500 Received: by mail-wm1-f65.google.com with SMTP id g67so537006wmd.2 for ; Mon, 04 Feb 2019 08:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jr/F2WIgj83bkpL8MW+IoICcaK/KaC+PEokoDFThc4s=; b=xYUbq1+na/vEYwpQpe3DsF8G/OmHUphDOzfsxanqnqKddG6z2ySg8kFlg+wlKqSy/r xWeqpyXlbssYYiJXNsgENaAecK6N77k0w5eiJzC9Za9NXv6+Na+Tej77yB1FkpdTNmeR N+8EU0oPPTOcnbd0RFPy2/KKplGHc0391d88C+vaE1yAIrwXzIHoWad+Oq0LltaAVnbh 2DJzaFSmj+S+tEMKx8/shxxbnE3cw/ZuweaB6JOh1HqqeHrvnDYZbfG5XBVQLNBoUxNi YX4kXwHV5NFlYMs04PadgAcaMUVp2WLiBQSdJY8URguAj9AHllA+ns861GWWHZsG+RiI yEzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jr/F2WIgj83bkpL8MW+IoICcaK/KaC+PEokoDFThc4s=; b=JB3VdRCW35E2oDTKcOHWXKedtk3MVlxOu0b/YnCB3t8Ufn8bkenEWrlwhfLkYTj26C UXwgTsWOB2AcFVo5NAdXZ9C9MCCpE/Ln/FoZ6YZJZ7uGPIiqn9llUTpzzp5L4HjFZ7Yr zo/Zkit+XLCoX8uS7JzF4t4CbAgKGJG+m8pKhAukMz6jlldeA34fEexn4yN5jHQLhcms i2bivx+k8rH8ANVOspYnN2M/kgdKzsyiMhHEkjeYsr8T+7QKnt/5aqoe646BzOx+ct9b R88vjEYcYHI8WA1X+S0u3ttOtfWjLPU8mnHHn+ASH1N3a79mySF1L67K7Ysi8raDXS3F GGbw== X-Gm-Message-State: AHQUAubXeFdDL6ryruG4BuAzseo6kxhfBY7Rm4AXGcionwD+nO0fUUqI kEOZzrdpBx8CY/9brX3Zdd/pzg== X-Google-Smtp-Source: AHgI3IaPO8bNFLuk3vDm3A5hMdB7wzxFWnpZBvoSPNGW1eBCIcB/nyliTF3Pm1DEY4KHi/yGsz6WuQ== X-Received: by 2002:a1c:2c6:: with SMTP id 189mr135104wmc.21.1549297511097; Mon, 04 Feb 2019 08:25:11 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id k3sm11584947wrm.7.2019.02.04.08.25.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 08:25:10 -0800 (PST) Date: Mon, 4 Feb 2019 17:16:02 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH iproute2-next v5] devlink: add info subcommand Message-ID: <20190204161602.GA11362@nanopsycho> References: <20190204161011.7808-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204161011.7808-1-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 05:10:11PM CET, jakub.kicinski@netronome.com wrote: >Add support for reading the device serial number, driver name >and various versions. Example: > >$ devlink dev info pci/0000:82:00.0 >pci/0000:82:00.0: > driver nfp > serial_number 16240145 > versions: > fixed: > board.id AMDA0081-0001 > board.rev 15 > board.vendor SMA > board.model hydrogen > running: > fw.mgmt 010181.010181.0101d4 > fw.cpld 0x1030000 > fw.app abm-d372b6 > fw.undi 0.0.2 > chip.init AMDA-0081-0001 20160318164536 > stored: > fw.mgmt 010181.010181.0101d4 > fw.app abm-d372b6 > fw.undi 0.0.2 > chip.init AMDA-0081-0001 20160318164536 > >$ devlink -jp dev info pci/0000:82:00.0 >{ > "info": { > "pci/0000:82:00.0": { > "driver": "nfp", > "serial_number": "16240145", > "versions": { > "fixed": { > "board.id": "AMDA0081-0001", > "board.rev": "15", > "board.vendor": "SMA", > "board.model": "hydrogen" > }, > "running": { > "fw.mgmt": "010181.010181.0101d4", > "fw.cpld": "0x1030000", > "fw.app": "abm-d372b6", > "fw.undi": "0.0.2", > "chip.init": "AMDA-0081-0001 20160318164536" > }, > "stored": { > "fw.mgmt": "010181.010181.0101d4", > "fw.app": "abm-d372b6", > "fw.undi": "0.0.2", > "chip.init": "AMDA-0081-0001 20160318164536" > } > } > } > } >} > >v5: > - remove spurious new line. >v4: > - more commit message improvements. >v3: > - show up-to-date output in the commit message. >v2 (Jiri): > - remove filtering; > - add example in the commit message. >RFCv2: > - make info subcommand of dev. > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko Thanks!