From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21C6C282C4 for ; Mon, 4 Feb 2019 16:30:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B2F12087C for ; Mon, 4 Feb 2019 16:30:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="D6GaNbs8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729860AbfBDQaP (ORCPT ); Mon, 4 Feb 2019 11:30:15 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:37483 "EHLO mail-wr1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727058AbfBDQaO (ORCPT ); Mon, 4 Feb 2019 11:30:14 -0500 Received: by mail-wr1-f52.google.com with SMTP id s12so511554wrt.4 for ; Mon, 04 Feb 2019 08:30:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7BydYPGl314D1lv6JdqaWcSGEIRtSMO6CUSEOfy0bJs=; b=D6GaNbs873T6jfv/m3DObcHhgE0iYVAeHzPqLLARS8El3Asxy5apG85qFv3ZtP2U+3 drCuGAWzv7WVMjQmsgPjtA9VkNdT4HeESAikQ8cDBJaVlOQJFtFNnYLDUc0NzxAgd8kD vWO3nO3DR0EUY63d31C1KRJlt8IkI1uhC9FWf15doUqHjm+VNdZ7bIyTjXNZhAxjLn3u rPjrdCV6wo64uOt1Eq6l0PfXiTNM3OTKHJ1Qcc1YCgGd5TvJ2G0CIaPQdqvDnYcr563t Gm/nZRzuJ0v1acagdIpdnRDjF318XELVFEpktDNZS/p9IIQtLlBYB1MSdX0fm0RJR1Tj 3Uww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7BydYPGl314D1lv6JdqaWcSGEIRtSMO6CUSEOfy0bJs=; b=BhRg7qKByAs7PvS1RqF4m3Ht4go1V7dPVgSD/luKAZKbuyuPFVO0bhU+s2Jc2XrscZ K2tNkxdWxQpmPKd/IoqbJN9HGs4FGgbmY/hGwyUBIVpq3Cgaok2luRwqrmxkyIritjyI awRJ5mYo9YvrCrB2VS73zU9qKt2zOMxmV8GOcZYFnqABuX1MlFmlDSP66GjQQdx8hg9g +JnQf5KbfD91c3NyqC3SAtKJA9mOQ/KyGeyxO76xt3hECK/jDgM0YTyBNx9xjsgG4XP6 wgYFqqPdhARiENnHBc4hPO9JBBb8YiGyp1PKFVdpZz1hG/3EyoVlbsiqh559/NlDkMQU SiUg== X-Gm-Message-State: AHQUAubAFSPz3RxelXozph011rfzPWo48vYHVolOqvPhwEDoGiQSnHGh W0+yR265zR4mjC2LSv6KoWYSpAWP+NY= X-Google-Smtp-Source: AHgI3IZX1cGYO/2Ck36ZYRX6GeYfAQzNlgnWO5vkKMQLHME6/A5mria28tlH4i6Hp3P/D+CDVqQ+EQ== X-Received: by 2002:a5d:570c:: with SMTP id a12mr141989wrv.161.1549297813189; Mon, 04 Feb 2019 08:30:13 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id s16sm15681896wrt.77.2019.02.04.08.30.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 08:30:12 -0800 (PST) Date: Mon, 4 Feb 2019 17:21:04 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net Subject: Re: [PATCH net-next v3 02/16] net: sched: refactor tc_ctl_chain() to use block->lock Message-ID: <20190204162104.GB11362@nanopsycho> References: <20190204123301.4223-1-vladbu@mellanox.com> <20190204123301.4223-3-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204123301.4223-3-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 01:32:47PM CET, vladbu@mellanox.com wrote: >In order to remove dependency on rtnl lock, modify chain API to use >block->lock to protect chain from concurrent modification. Rearrange >tc_ctl_chain() code to call tcf_chain_hold() while holding block->lock to >prevent concurrent chain removal. > >Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko