From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74134C282C4 for ; Mon, 4 Feb 2019 16:40:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3583720823 for ; Mon, 4 Feb 2019 16:40:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="YghL8JpN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727794AbfBDQkH (ORCPT ); Mon, 4 Feb 2019 11:40:07 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37240 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbfBDQkG (ORCPT ); Mon, 4 Feb 2019 11:40:06 -0500 Received: by mail-wr1-f67.google.com with SMTP id s12so550626wrt.4 for ; Mon, 04 Feb 2019 08:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6c6ZBKv9amvIWL/cQdPF/QLx037PwIjdVrPheOqOSPI=; b=YghL8JpNC4yto7wIGGtjUU+vYMTn7671msMovo9L5wg7G3z83Zd+kaMilOXrYwlwWy t+6Ar1tJJwc7qCtQt/MMKF3XZtXCj5IEQuvZ67UaW8y+jPzrmHCIDSQL5teNDVfQya4p UD+KNMVIbyCjy6rnjqta1vUaTxQLDuMlHtpQwEtT81xPpevorAZabpk7tJaRhJDOF1S7 fcopdfxVB3jnkA0YE8rFkBUWmFBqvzqVNt0ePrudAc9iGsWoMRdKOSi68OPOq7vJDT3s e/yovp5R1Fgkd/0YnMGsUUJTattxaOd45l1fkuMSriTKtMkDqoTU8ePnsq9BZZSlbqmK sFdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6c6ZBKv9amvIWL/cQdPF/QLx037PwIjdVrPheOqOSPI=; b=LhsA/USON75qvSKplDIjTW+xVTBOqENNDJUBL4a8239JPzPiRzivLa7jxRk6y9hBsR BpuOH3wlwAlwEhO+B4SzZJbR/do+8sSxUITho84bCBBH8jOfRL1dUUMnHC7vynXfh46T FH3DRRzGzrkLUN8RI9kzVZ7etBKgGKVNvFFRK+zkwZ0KRZW2d1mB8qzXsa7sn0spEihg C7/nbs+m+7p6k3itS9jvPDhu6hTj/YeoU+T2zZy8ZpZYhcFl1MB8uLzC/ds9XI5LHU62 i5akONyxxLjA9snO+KkGJ6McJCiKwEU3dWseO1MSABzxvanxkS7RhHGaBQRY3LPtsS1k V9UQ== X-Gm-Message-State: AHQUAuami9kp2r/yc4zp1rvde0AbMW04IKyfW0C60Ddys2a1kO8EI0lw xLH7BcMBWFd1pFW783HBAIk6Lg== X-Google-Smtp-Source: AHgI3IZKzv3uDYGdShmi038SltcVUseg3Y9ZlrF5v4eVWNZo/2qElLPF+1/8eSoxTeAXuPOmmNSbOQ== X-Received: by 2002:a5d:4d49:: with SMTP id a9mr253342wru.50.1549298405225; Mon, 04 Feb 2019 08:40:05 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id y20sm11943532wra.51.2019.02.04.08.40.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 08:40:04 -0800 (PST) Date: Mon, 4 Feb 2019 17:30:56 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net Subject: Re: [PATCH net-next v3 03/16] net: sched: protect block->chain0 with block->lock Message-ID: <20190204163056.GC11362@nanopsycho> References: <20190204123301.4223-1-vladbu@mellanox.com> <20190204123301.4223-4-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204123301.4223-4-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 01:32:48PM CET, vladbu@mellanox.com wrote: >In order to remove dependency on rtnl lock, use block->lock to protect >chain0 struct from concurrent modification. Rearrange code in chain0 >callback add and del functions to only access chain0 when block->lock is >held. > >Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko