From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ABDCC282C4 for ; Mon, 4 Feb 2019 18:43:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DCFB217D6 for ; Mon, 4 Feb 2019 18:43:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lSM/epmh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729597AbfBDSnZ (ORCPT ); Mon, 4 Feb 2019 13:43:25 -0500 Received: from mail-it1-f202.google.com ([209.85.166.202]:56655 "EHLO mail-it1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbfBDSnW (ORCPT ); Mon, 4 Feb 2019 13:43:22 -0500 Received: by mail-it1-f202.google.com with SMTP id 135so1310959itb.6 for ; Mon, 04 Feb 2019 10:43:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=mnwGOvUN92mhLcxzq+5EJ7aYymqjnTFNyP0S6kL/jMA=; b=lSM/epmh3ULNmbHYcx10PIV28I4FVq3cpZ0LZL4m85YG01gTSea27ZVVX255yVeQsB g39DFY7MdY+pCo8YAiK8B/Drk1MXwbA1+sIfRP8SJiZKli1e85bXQOxF2CXf4aMFTcsX g4A54LHZu97mcboajnWq+D460wSl7mXilrq4ZBjPNots49wuCrwCZN1813UvaT5Y9sQQ O5T1z1FMWeA5W0Tzk2+WtsBc6lM08vJf2WrvkCkeOfTY3gw3lRMRpVnoD79RwPlY9nOT 6x4v4Wr4//s2mjL2UpyvBzbeJewjJfvRiCmbnT+Oc8bD+4h7PdKx4WZvVlN3EmUWuDGh TXHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=mnwGOvUN92mhLcxzq+5EJ7aYymqjnTFNyP0S6kL/jMA=; b=O6gc2T7ja3iv/p0DMR8NH5qbUV4QTP8HSp6bJkXyrFuNspgi3kidHtm1NXqvooQn9p eU8Tey16ZphNHh/H/9ZBZOEWKP7TqdbsqjHRYsDlSLjQtug4TVp/KtXOXFckzTMBqyCA bTRjcBXsUFjUdLHp+eB5u/gXXDm/zJo8rKQAYzQXStvmr0CzTWOGgEgIi/h1yTkeSiJM i+VwLhXSmLtLtwmpK9ILDA6XTR/uy+dVUn1MwHzQn1/mQrCJ2xES3rTmrPb4zpgFccCp wOPeoZjV0EfzxhCWE4IHYOxqrupsG9w/AsrR+QMhAnTuP4Qj+y+7YgYa8ScEYgbnb35G M3DQ== X-Gm-Message-State: AHQUAubvzYpyjNq5of8RsH6smdQhy1Os91bOadmzKhRE/Uj8BnAM/Kef MRLbec99WF6SlIgivO++1Z/j2uonebZTAdD3UwKIlQkW/l44nRfD6C5gJ7sw+no3r8hsSnw1RTj WUCH31B/jKAh9iRw4PeZIbgI+368KlrfYXZCPmJD2xdF0cMcLbN0r6A== X-Google-Smtp-Source: AHgI3IZ9SxQpZYoLcrDO0995bfDnTvCo5gnZW5mr6vwE9+9OQALLKUndwzTzcC568ke3CZt7JXeTWGk= X-Received: by 2002:a24:6504:: with SMTP id u4mr435097itb.25.1549305801886; Mon, 04 Feb 2019 10:43:21 -0800 (PST) Date: Mon, 4 Feb 2019 10:43:19 -0800 Message-Id: <20190204184319.177504-1-sdf@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.20.1.611.gfbb209baf1-goog Subject: [PATCH bpf-next] selftests/bpf: use localhost in tcp_{server,client}.py From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bind and connect to localhost. There is no reason for this test to use non-localhost interface. This lets us run this test in a network namespace. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/tcp_client.py | 3 +-- tools/testing/selftests/bpf/tcp_server.py | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/bpf/tcp_client.py b/tools/testing/selftests/bpf/tcp_client.py index 7f8200a8702b..a53ed58528d6 100755 --- a/tools/testing/selftests/bpf/tcp_client.py +++ b/tools/testing/selftests/bpf/tcp_client.py @@ -30,12 +30,11 @@ import select serverPort = int(sys.argv[1]) -HostName = socket.gethostname() # create active socket sock = socket.socket(socket.AF_INET6, socket.SOCK_STREAM) try: - sock.connect((HostName, serverPort)) + sock.connect(('localhost', serverPort)) except socket.error as e: sys.exit(1) diff --git a/tools/testing/selftests/bpf/tcp_server.py b/tools/testing/selftests/bpf/tcp_server.py index b39903fca4c8..0ca60d193bed 100755 --- a/tools/testing/selftests/bpf/tcp_server.py +++ b/tools/testing/selftests/bpf/tcp_server.py @@ -35,13 +35,10 @@ MAX_PORTS = 2 serverPort = SERVER_PORT serverSocket = None -HostName = socket.gethostname() - # create passive socket serverSocket = socket.socket(socket.AF_INET6, socket.SOCK_STREAM) -host = socket.gethostname() -try: serverSocket.bind((host, 0)) +try: serverSocket.bind(('localhost', 0)) except socket.error as msg: print('bind fails: ' + str(msg)) -- 2.20.1.611.gfbb209baf1-goog