From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9624CC282C4 for ; Mon, 4 Feb 2019 20:19:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 639D32082E for ; Mon, 4 Feb 2019 20:19:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KSPKBxjU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727864AbfBDUTM (ORCPT ); Mon, 4 Feb 2019 15:19:12 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38489 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727645AbfBDUTL (ORCPT ); Mon, 4 Feb 2019 15:19:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Mpz8qhuDrY3ZZzW0mZexGtzodPS2DTassnh3dc6SGbQ=; b=KSPKBxjU7e/kTc9rwPr01kgL6z AYIwlJeCNPO7qDJ//uxFDmVyS5ZluW+zMcsgKICaF75AWcdk0tNpXEiwJn0vtHyh6lr6X6ik3sW5z 9v7EAIksvd0nS3R6Sa6D2vGAczb7dIu/27mUBlX0xqZsmSnd4RHZjpGHzDD8qy+eaRic=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gqkht-0000hH-0g; Mon, 04 Feb 2019 21:19:05 +0100 Date: Mon, 4 Feb 2019 21:19:05 +0100 From: Andrew Lunn To: John David Anglin Cc: Russell King , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org Subject: Re: [PATCH] net: phylink: dsa: mv88e6xxx: Revise irq setup ordering Message-ID: <20190204201905.GA2488@lunn.ch> References: <20190123002240.GF3634@lunn.ch> <20190130172818.GJ21904@lunn.ch> <2ea9fd81-f92d-9505-dd0b-bdd0f67d8ce7@bell.net> <20190130223846.GB30115@lunn.ch> <9415d82e-965b-7777-0ad0-f23d6c9f177e@bell.net> <53b49df8-53ed-704f-9197-230b18d83090@bell.net> <20190204193518.GE24989@lunn.ch> <2d8c0eff-00cd-31c7-9906-89ff9d3c7dd4@bell.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d8c0eff-00cd-31c7-9906-89ff9d3c7dd4@bell.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Can you be more specific regarding what you think is wrong with this hunk? Hi David The IRQ core would do this if it was needed. How many other irq thread work functions can you point to which do something similar? Andrew