From: David Miller <davem@davemloft.net>
To: chunkeey@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: emac: remove IBM_EMAC_RX_SKB_HEADROOM
Date: Tue, 05 Feb 2019 10:36:45 -0800 (PST) [thread overview]
Message-ID: <20190205.103645.1734903579761130412.davem@davemloft.net> (raw)
In-Reply-To: <20190204215829.27063-1-chunkeey@gmail.com>
From: Christian Lamparter <chunkeey@gmail.com>
Date: Mon, 4 Feb 2019 22:58:29 +0100
> @@ -1195,6 +1195,27 @@ static inline int emac_alloc_rx_skb(struct emac_instance *dev, int slot,
> return 0;
> }
>
> +static inline int
> +emac_alloc_rx_skb(struct emac_instance *dev, int slot)
> +{
> + struct sk_buff *skb;
> +
> + skb = __netdev_alloc_skb_ip_align(dev->ndev, dev->rx_skb_size,
> + GFP_KERNEL);
> +
> + return __emac_prepare_rx_skb(skb, dev, slot);
> +}
> +
> +static inline int
> +emac_alloc_rx_skb_napi(struct emac_instance *dev, int slot)
> +{
> + struct sk_buff *skb;
> +
> + skb = napi_alloc_skb(&dev->mal->napi, dev->rx_skb_size);
> +
> + return __emac_prepare_rx_skb(skb, dev, slot);
> +}
> +
Do not use the inline keyword in foo.c files, let the compiler decide.
Thank you.
prev parent reply other threads:[~2019-02-05 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 21:58 [PATCH v2] net: emac: remove IBM_EMAC_RX_SKB_HEADROOM Christian Lamparter
2019-02-05 18:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205.103645.1734903579761130412.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chunkeey@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).